Add Flow Label to concepts in docs #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krdln
changed the title
DariaKunoichi
approved these changes
Sep 1, 2022
There was a problem hiding this comment.
Reviewed 18 of 18 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @krdln)
This page is now the source of truth about flow labels. Previously it was partially documented in selector reference, now selector just links to Flow Label page. Also: * pulled out Service out of Selector (stub), * added stub pages for fluxmeters and classifier (so that we can link to them).
krdln
force-pushed
the
concepts-classifier
branch
from
100223f to
893ddbb
Compare
DariaKunoichi
changed the title
DariaKunoichi
approved these changes
Sep 2, 2022
harjotgill
pushed a commit
that referenced
this pull request
Sep 9, 2022
This page is now the source of truth about flow labels. Previously it was partially documented in selector reference, now selector just links to Flow Label page. Also: * pulled out Service out of Selector (stub), * added stub pages for fluxmeters and classifier (so that we can link to them).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When documenting flow classifiers, I realized we refer to flow labels in
various places, but never defined what it was
Preview: https://deploy-preview-54--aperture-tech-docs.netlify.app/docs/development/concepts/flow-control/label/
This page is now the source of truth about flow labels.
Previously it was partially documented in selector reference, not
selector just links to Flow Label page.
Also:
This change is