Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add accept words for blog #3151

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Add accept words for blog #3151

merged 2 commits into from
Jan 16, 2024

Conversation

hdkshingala
Copy link
Contributor

@hdkshingala hdkshingala commented Jan 16, 2024

Summary by CodeRabbit

  • Documentation
    • Expanded the FluxNinja vocabulary with new terms, including "Grammarly," "chatbots," "gameplay," "composable," and "productionize."
    • Updated the documentation to reflect the removal of the kubelet scraper, changed "kubelet" to "Kubelet" for consistency, and clarified the deprecation of the related flag.

@hdkshingala hdkshingala requested a review from a team as a code owner January 16, 2024 07:08
Copy link
Contributor

coderabbitai bot commented Jan 16, 2024

Walkthrough

The update involves expanding the vocabulary for "FluxNinja" with the inclusion of modern and technical terms. These additions reflect an engagement with contemporary digital tools and concepts, suggesting a possible evolution or enhancement of the "FluxNinja" domain towards more advanced technological interactions and implementations.

Changes

File Path Change Summary
.github/.../FluxNinja/accept.txt
cmd/aperture-agent/config/types.go
docs/content/reference/configuration/agent.md
Added terms to FluxNinja vocabulary. Changed comment for DisableKubeletScraper field. Updated documentation to reflect removal of kubelet scraper and deprecation of related flag.

🐇✨
To the lexicon's delight, we hop and weave,
"Grammarly" and "bots" in the digital sleeve.
"Gameplay" winks, "composable" dances in line,
"Productionize" the craft, oh ninja of mine! 🌟🥋


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 145929c and 12144f8.
Files selected for processing (1)
  • .github/styles/config/vocabularies/FluxNinja/accept.txt (1 hunks)
Additional comments: 5
.github/styles/config/vocabularies/FluxNinja/accept.txt (5)
  • 127-127: The term "Grammarly" has been correctly added to the vocabulary list.
  • 128-128: The term "chatbots" has been correctly added to the vocabulary list.
  • 129-129: The term "gameplay" has been correctly added to the vocabulary list.
  • 130-130: The term "composable" has been correctly added to the vocabulary list.
  • 131-131: The term "productionize" has been correctly added to the vocabulary list.

@hdkshingala hdkshingala requested review from a team as code owners January 16, 2024 07:15
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 12144f8 and daba387.
Files ignored due to path filters (3)
  • docs/gen/config/agent/config-swagger.yaml is excluded by: !**/*.yaml, !**/gen/**
  • manifests/charts/aperture-agent/crds/fluxninja.com_agents.yaml is excluded by: !**/*.yaml
  • operator/config/crd/bases/fluxninja.com_agents.yaml is excluded by: !**/*.yaml
Files selected for processing (2)
  • cmd/aperture-agent/config/types.go (1 hunks)
  • docs/content/reference/configuration/agent.md (1 hunks)
Files skipped from review due to trivial changes (1)
  • docs/content/reference/configuration/agent.md

cmd/aperture-agent/config/types.go Show resolved Hide resolved
@hdkshingala hdkshingala merged commit 6b8b6e2 into main Jan 16, 2024
17 of 25 checks passed
@hdkshingala hdkshingala deleted the allow-accept-words branch January 16, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant