Add Concurrency Schedulers to OLAP telemetry

[kwapik]

Description of change

This adds missing scheduler do OLAP telemetry.

Checklist

• Tested in playground or other setup
• Screenshot (Grafana) from playground added to PR for 15+ minute run
• Documentation is changed or added
• Tests and/or benchmarks are included
• Breaking changes

Summary by CodeRabbit

• New Features
  • Expanded the set of labels for rate limiters and schedulers, including new labels for Aperture, concurrency schedulers, and dropping concurrency schedulers.
• Enhancements
  • Improved label handling in the metrics processor to support new scheduler and rate limiter labels.

[coderabbitai]

Walkthrough

The recent updates aim to enhance the OpenTelemetry Collector by introducing new constants and labels related to concurrency schedulers and their management, including aspects like rate limiting and dropping. These changes refine the system's monitoring capabilities, offering more granular control and insights into the performance and behavior of schedulers within the metrics processing pipeline.

Changes

Files	Summary
pkg/otelcollector/consts/consts.go pkg/otelcollector/metricsprocessor/internal/labels_filter.go	Introduced new constants for concurrency schedulers and dropping concurrency schedulers.
pkg/otelcollector/metricsprocessor/internal/check_response_labels.go pkg/otelcollector/metricsprocessor/internal/check_response_labels_test.go	Modified handling and testing for new labels related to Aperture, concurrency schedulers, and dropping concurrency schedulers.

🐇✨
In the realm of code, where the data streams flow,
New labels emerge, in the metrics they glow.
With schedulers set, and the dropped ones we know,
A rabbit hops on, through the digital snow.
🌟🐾

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between a944906 and 3976554.

Files selected for processing (4)

• pkg/otelcollector/consts/consts.go (1 hunks)
• pkg/otelcollector/metricsprocessor/internal/check_response_labels.go (6 hunks)
• pkg/otelcollector/metricsprocessor/internal/check_response_labels_test.go (1 hunks)
• pkg/otelcollector/metricsprocessor/internal/labels_filter.go (1 hunks)

Files skipped from review due to trivial changes (1)

• pkg/otelcollector/consts/consts.go

Additional comments: 5

pkg/otelcollector/metricsprocessor/internal/labels_filter.go (1)

• 30-31: Added new constants otelconsts.ApertureConcurrencySchedulersLabel and otelconsts.ApertureDroppingConcurrencySchedulersLabel to the list of predefined labels. Ensure these constants are correctly defined in consts.go and used consistently across the codebase.

pkg/otelcollector/metricsprocessor/internal/check_response_labels_test.go (1)

• 108-128: The test case "Sets concurrency schedulers" correctly adds and verifies the handling of concurrency schedulers and dropping concurrency schedulers labels based on the CheckResponse. This ensures the new functionality is covered by unit tests.

pkg/otelcollector/metricsprocessor/internal/check_response_labels.go (3)

• 36-39: Added comments for new labels otelconsts.ApertureSamplersLabel, otelconsts.ApertureDroppingSamplersLabel, otelconsts.ApertureConcurrencySchedulersLabel, and otelconsts.ApertureDroppingConcurrencySchedulersLabel. This documentation helps maintain clarity on the purpose and usage of these labels.
• 90-96: Introduced slices for dropping and non-dropping concurrency schedulers, ensuring that these new categories are correctly initialized for label addition. This is a crucial step for the correct functioning of the AddCheckResponseBasedLabels function with the new labels.
• 174-185: The handling of concurrency scheduler decisions within AddCheckResponseBasedLabels is correctly implemented, matching the pattern used for other decision types. This ensures that labels for concurrency schedulers and their dropping counterparts are accurately reflected in telemetry data.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 617b972 and 9d6d853.

Files selected for processing (4)

• pkg/otelcollector/consts/consts.go (1 hunks)
• pkg/otelcollector/metricsprocessor/internal/check_response_labels.go (6 hunks)
• pkg/otelcollector/metricsprocessor/internal/check_response_labels_test.go (1 hunks)
• pkg/otelcollector/metricsprocessor/internal/labels_filter.go (1 hunks)

Files skipped from review as they are similar to previous changes (4)

• pkg/otelcollector/consts/consts.go
• pkg/otelcollector/metricsprocessor/internal/check_response_labels.go
• pkg/otelcollector/metricsprocessor/internal/check_response_labels_test.go
• pkg/otelcollector/metricsprocessor/internal/labels_filter.go