Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add authzHandler to sdk-validator's grpc server #797

Merged
merged 24 commits into from
Nov 7, 2022
Merged

Conversation

hasit
Copy link
Contributor

@hasit hasit commented Oct 19, 2022

Description of change

Add authzHandler to sdk-validator's grpc server

  • Add CommonHandler
  • Refactor FlowControlHandler with CommonHandler
Checklist
  • Tested in playground or other setup
  • Documentation is changed or added
  • Tests and/or benchmarks are included
  • Breaking changes

This change is Reviewable

- Add CommonHandler
- Refactor FlowControlHandler with CommonHandler
@hasit hasit requested a review from a team as a code owner October 19, 2022 23:54
@hasit hasit self-assigned this Oct 19, 2022
@hasit hasit marked this pull request as draft October 19, 2022 23:54
@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Base: 37.61% // Head: 37.54% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (56b5547) compared to base (993ccc8).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #797      +/-   ##
==========================================
- Coverage   37.61%   37.54%   -0.08%     
==========================================
  Files         285      286       +1     
  Lines       20819    20852      +33     
==========================================
- Hits         7831     7828       -3     
- Misses      12506    12541      +35     
- Partials      482      483       +1     
Impacted Files Coverage Δ
cmd/sdk-validator/main.go 1.40% <0.00%> (-0.20%) ⬇️
cmd/sdk-validator/validator/common.go 0.00% <0.00%> (ø)
cmd/sdk-validator/validator/flowcontrol.go 0.00% <0.00%> (ø)
cmd/sdk-validator/validator/trace.go 0.00% <0.00%> (ø)
pkg/jobs/job.go 80.62% <0.00%> (-2.33%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tanveergill
Copy link
Contributor

@hasit,
What’s this blocked on? Please try to get this to completion

@hasit hasit marked this pull request as ready for review November 4, 2022 17:14
@pull-request-size pull-request-size bot added size/L and removed size/M labels Nov 4, 2022
@hasit hasit merged commit 2bbfe8d into main Nov 7, 2022
@hasit hasit deleted the sdk-validator-authz branch November 7, 2022 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants