Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dry run mode for Load Actuator #826

Merged
merged 3 commits into from
Oct 27, 2022
Merged

Conversation

tanveergill
Copy link
Contributor

@tanveergill tanveergill commented Oct 27, 2022

Description of change

  • Dry run mode for Load Actuator. No traffic can get dropped due to this Load Actuator in this mode. Useful for observing the behavior of Load Actuator without any disruptions.
  • TokenBucketLoadMultiplier has a new Pass through mode
  • Default to Pass through mode in case multiplier is invalid and also when there is no decision available at the Agent including initialization
  • Rename init_config -> default_config
  • Fallback to default_config on dynamicConfig deletion - earlier it was staying on last dynamicConfig which was not expected
Checklist
  • Tested in playground or other setup
  • Documentation is changed or added

This change is Reviewable

@tanveergill tanveergill marked this pull request as ready for review October 27, 2022 02:48
@tanveergill tanveergill requested review from a team as code owners October 27, 2022 02:48
@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Base: 37.26% // Head: 37.19% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (0b07c0b) compared to base (cf7f810).
Patch coverage: 11.56% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #826      +/-   ##
==========================================
- Coverage   37.26%   37.19%   -0.08%     
==========================================
  Files         273      273              
  Lines       20400    20470      +70     
==========================================
+ Hits         7603     7613      +10     
- Misses      12314    12372      +58     
- Partials      483      485       +2     
Impacted Files Coverage Δ
pkg/policies/common/paths.go 100.00% <ø> (ø)
...rolplane/components/actuators/rate/rate-limiter.go 16.10% <0.00%> (-0.56%) ⬇️
...plane/actuators/concurrency/concurrency-limiter.go 0.00% <0.00%> (ø)
...s/dataplane/actuators/concurrency/load-actuator.go 0.00% <0.00%> (ø)
...currency/scheduler/token-bucket-load-multiplier.go 87.23% <0.00%> (-12.77%) ⬇️
.../policies/dataplane/actuators/rate/rate-limiter.go 0.00% <0.00%> (ø)
.../components/actuators/concurrency/load-actuator.go 14.03% <13.63%> (-3.69%) ⬇️
...lane/components/controller/controller-component.go 14.28% <43.75%> (+2.67%) ⬆️
...ies/controlplane/components/controller/gradient.go 28.20% <100.00%> (ø)
...taplane/resources/classifier/extractors/compile.go 79.14% <0.00%> (+0.61%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tanveergill tanveergill merged commit d31448c into main Oct 27, 2022
@tanveergill tanveergill deleted the tgill/load-actuator-dry-run branch October 27, 2022 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants