Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TickInfo in LoadDecision #836

Merged
merged 4 commits into from
Oct 29, 2022
Merged

Conversation

tanveergill
Copy link
Contributor

@tanveergill tanveergill commented Oct 28, 2022

Description of change

  • Put TickInfo in LoadDecision` to re-trigger fill-rate evaluation at Agent.
  • Remove redundant Dry Run lock in LoadActuator at Controller since its already under Circuit Execution Lock.
Checklist
  • Tested in playground or other setup

This change is Reviewable

… at Agent. Remove redundant Dry Run lock in LoadActuator at Controller since its already under Circuit Execution Lock
@tanveergill tanveergill marked this pull request as ready for review October 28, 2022 22:13
@tanveergill tanveergill requested review from a team as code owners October 28, 2022 22:13
@tanveergill tanveergill enabled auto-merge (squash) October 29, 2022 00:22
@codecov
Copy link

codecov bot commented Oct 29, 2022

Codecov Report

Base: 37.47% // Head: 37.46% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (b109dba) compared to base (1c5790b).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head b109dba differs from pull request most recent head 4f8e19e. Consider uploading reports for the commit 4f8e19e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #836      +/-   ##
==========================================
- Coverage   37.47%   37.46%   -0.01%     
==========================================
  Files         278      278              
  Lines       20490    20494       +4     
==========================================
  Hits         7678     7678              
- Misses      12332    12336       +4     
  Partials      480      480              
Impacted Files Coverage Δ
.../components/actuators/concurrency/load-actuator.go 14.41% <0.00%> (+0.37%) ⬆️
pkg/policies/controlplane/runtime/tick-info.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tanveergill tanveergill merged commit 367c5c8 into main Oct 29, 2022
@tanveergill tanveergill deleted the tgill/tick-info-in-load-decision branch October 29, 2022 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants