Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

panichandler: process panic handlers in the same go routine #875

Merged
merged 3 commits into from
Nov 1, 2022

Conversation

harjotgill
Copy link
Contributor

@harjotgill harjotgill commented Nov 1, 2022

Description of change

Sentry runs it's own stack capture therefore it's better to run the handler in the same go routine that panic'ed. Otherwise Sentry is unable to distinguish crashes from one another.

Checklist
  • Tested in playground or other setup

This change is Reviewable

@harjotgill harjotgill requested a review from a team as a code owner November 1, 2022 21:26
@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Base: 37.47% // Head: 37.50% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (1cb212e) compared to base (274d547).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #875      +/-   ##
==========================================
+ Coverage   37.47%   37.50%   +0.03%     
==========================================
  Files         278      278              
  Lines       20557    20542      -15     
==========================================
+ Hits         7703     7705       +2     
+ Misses      12373    12357      -16     
+ Partials      481      480       -1     
Impacted Files Coverage Δ
pkg/panichandler/panichandler.go 50.00% <0.00%> (+6.89%) ⬆️
...vice/aperture-plugin-sentry/sentry/sentrywriter.go 0.00% <0.00%> (ø)
...taplane/resources/classifier/extractors/compile.go 78.52% <0.00%> (-0.62%) ⬇️
pkg/jobs/job.go 82.94% <0.00%> (+2.32%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pull-request-size pull-request-size bot added size/M and removed size/S labels Nov 1, 2022
@harjotgill harjotgill merged commit c9b8ee7 into main Nov 1, 2022
@harjotgill harjotgill deleted the panichandler branch November 1, 2022 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant