Add metrics for IP-to-services lookups #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwapik
approved these changes
Dec 5, 2022
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @krdln)
Codecov ReportBase: 42.87% // Head: 42.84% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #997 +/- ##
==========================================
- Coverage 42.87% 42.84% -0.03%
==========================================
Files 295 296 +1
Lines 21308 21339 +31
==========================================
+ Hits 9135 9143 +8
- Misses 11615 11638 +23
Partials 558 558
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
hdkshingala
pushed a commit
that referenced
this pull request
Dec 5, 2022
Adds a `service_lookups_total` metric which tracks IP-to-services lookups (via entity cache). To differentiate between successful and failed lookups, status=OK/Error label can be used. Resolves #882
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Adds a
service_lookups_totalmetric which tracks IP-to-services lookups (viaentity cache). To differentiate between successful and failed lookups,
status=OK/Error label can be used.
Resolves #882
Checklist
This change is