-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(a380x/oans): EXIT missed, flags/crosses, visual fixes #9725
feat(a380x/oans): EXIT missed, flags/crosses, visual fixes #9725
Conversation
ec3c825
to
f334ad1
Compare
...e/flybywire-aircraft-a380-842/SimObjects/AirPlanes/FlyByWire_A380_842/model/A380_COCKPIT.xml
Show resolved
Hide resolved
# Conflicts: # fbw-a380x/src/systems/instruments/src/ND/OansControlPanel.tsx # fbw-a380x/src/systems/instruments/src/ND/instrument.tsx
fbw-a380x/src/systems/instruments/src/MFD/pages/common/MouseCursor.tsx
Outdated
Show resolved
Hide resolved
fbw-a380x/src/systems/instruments/src/MFD/pages/common/MouseCursor.tsx
Outdated
Show resolved
Hide resolved
fbw-common/src/systems/instruments/src/OANC/OancMarkerManager.ts
Outdated
Show resolved
Hide resolved
fbw-common/src/systems/instruments/src/OANC/OancMarkerManager.ts
Outdated
Show resolved
Hide resolved
fbw-common/src/systems/instruments/src/OANC/OancMarkerManager.ts
Outdated
Show resolved
Hide resolved
fbw-common/src/systems/instruments/src/OANC/OancMovingModeOverlay.tsx
Outdated
Show resolved
Hide resolved
fbw-common/src/systems/instruments/src/OANC/OancControlPanelUtils.ts
Outdated
Show resolved
Hide resolved
bfb07e2
to
816ca4c
Compare
# Conflicts: # .github/CHANGELOG.md
# Conflicts: # .github/CHANGELOG.md # fbw-a380x/src/systems/instruments/src/PFD/FMA.tsx
# Conflicts: # .github/CHANGELOG.md
@@ -663,6 +663,7 @@ | |||
"Left": "Left", | |||
"LoadOnly": "Load Only", | |||
"None": "None", | |||
"OansPerformanceMode": "OANS Performance Mode (Un-Load Airport Map When Not Used)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"OansPerformanceMode": "OANS Performance Mode (Un-Load Airport Map When Not Used)", | |
"OansPerformanceMode": "OANS Performance Mode (Unload Airport Map When Not Used)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I be inclined to just name the setting "Unload OANS Maps When Not Used" in the same style as all our other settings. None of them have a marketing name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't want to get too specific here, there could be several other improvements in the future which could slightly worsen the OANS experience for performance gain (reduction of resolution, reduction of update rate, disabling "RWY AHEAD", ...), might make sense to group them under one setting so we don't blow up the page.
# Conflicts: # .github/CHANGELOG.md
# Conflicts: # .github/CHANGELOG.md # fbw-a380x/src/systems/instruments/src/ND/OansControlPanel.tsx
Quality Assurance Tester Report Discord Username : utkrishtm Testing Process: Tested Airport: OMDB by iniBuilds, EHAM by FlyTampa, KJFK by iniBuilds Issue Fixes:
Context Menu Functionality:
BTV Testing:
OANS Performance Mode:
Circuit Breaker for ARPT NAV: Testing Results: Conclusions:
|
I forgot to comment, Over the last few days I flew a couple flights with this build. Right before takeoff I pull the ARPT NAV reset and it clears OANS from memory correctly. 10 minutes before TOD I go to set up my BTV, and the OANS is stuck on loading, the airport map never loads. To solve this, I had to relink navigraph. @utkrishtm did u ever encounter this? |
Yea so the map wouldn't load which is expected as it clears everything out. However if you choose the airport and click on Display Airport, it comes up. Make sure that the circuit breaker for ARPT NAV is clicked in before that. I did not test it the way you are. Try this and if it doesn't work ill test it again with what you did. |
Did you load an airport manually, as @utkrishtm described? |
I just tested how @aadee9940 did, and after clicking display airport again, it works fine. No need to relink Navigraph. |
@flogross89 @utkrishtm Yep so, when setting up BTV, I go to Plan Mode, zoom in till the OANS GUI pops up, Then going over to ARPT SEL tab, i had my departure and destination airport, KMIA, EGLL. After clicking on display airport for both and waiting upwards of 3-4 minutes, still nothing showed up. Hence stuck on loading. I did verify the ARPT NAV reset was in and not active. Another test I did was to simply monitor VRAM usage, when Oans is being used it can use upwards of 800-900mb, which is noticeable in the dev display. When I encountered this bug, the VRAM did not fill up as it was stuck on loading. After relinking navi, the vram usage went up and oans loaded in properly. If both of you do not encounter this issue, then something might me up with my navigraph, thats my guess. Sorry for the bother |
# Conflicts: # .github/CHANGELOG.md
That is still not correct FYI @flogross89. It should be above the other stuff. |
Fixes #9672
Fixes #9514
Fixes #9798
Summary of Changes
Out of scope:
Screenshots (if necessary)
References
Additional context
Discord username (if different from GitHub): floridude
Testing instructions
Build: https://www.swisstransfer.com/d/9567e151-f0b7-4576-8350-ee84c62d4f08 (use this instead of the GitHub build)
OANS Performance Mode:
Monitor VRAM: Should go up considerably when loading airports, should go down to similar levels as before when staying at least 60 seconds out of the ZOOM range mode
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.