Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(a380x/oans): EXIT missed, flags/crosses, visual fixes #9725

Merged
merged 39 commits into from
Feb 9, 2025

Conversation

flogross89
Copy link
Contributor

@flogross89 flogross89 commented Jan 6, 2025

Fixes #9672
Fixes #9514
Fixes #9798

Summary of Changes

  • Change color of mouse cursor to magenta if OANS visible
  • Add magenta lubber line in OANS ARC/NAV mode
  • Add EXIT MISSED logic, display in FMA and triple click
  • Update ARPT SEL on both sides when airport is selected manually
  • Add SET PLAN MODE (waiting for references)
  • Add option to select runways and taxiways via MAP DATA tab
  • Add option to center map on selected map data entities
  • Add option to add crosses and flags via the MAP DATA tab
  • Add option to add crosses and flags via the context menu
  • Add option to delete crosses and flags via the context menu
  • Enable TS strict mode, fix errors
  • Implement ARPT NAV reset panel p/b
  • Implement "OANS Performance Mode": Un-load airport if ND has been out of ZOOM mode for longer than one minute (or in ROSE ILS/VOR modes)

Out of scope:

  • LDG SHIFT

Screenshots (if necessary)

image

References

Additional context

Discord username (if different from GitHub): floridude

Testing instructions

Build: https://www.swisstransfer.com/d/9567e151-f0b7-4576-8350-ee84c62d4f08 (use this instead of the GitHub build)

  1. Confirm that issues are solved
  2. BTV: Perform landing, select exit before DRY line. "EXIT MISSED" should appear in the FMA once it becomes clear that the exit will be missed (confirmation time: 5 seconds)
  3. Select different runway, taxiways and parking stands through the MAP DATA tab, "CENTER MAP ON xxx" should work
  4. Adding flags and crosses to taxiways should work: One symbol at least every 250m, on each of the taxiway lines
  5. Addings flags and crosses should be possible via the context menu: Double click on desired location in the ND, select "ADD x"
  6. Pull ARPT NAV reset knob in overhead reset panel, OANS should be disabled

OANS Performance Mode:

  1. Enable "OANS Performance Mode" via the EFB
  2. Load airport in the OANS, ideally a performance-heavy one such as EDDF or EHAM
  3. Zoom into OANS ZOOM level via the EFIS CP
  4. Zoom out of ZOOM range via the EFIS CP, for example to 40nm
  5. Wait at least 60 seconds
  6. Zoom in to ZOOM range again, airport map should be loaded again (PLEASE WAIT displayed for a few seconds)
    Monitor VRAM: Should go up considerably when loading airports, should go down to similar levels as before when staying at least 60 seconds out of the ZOOM range mode

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

@flogross89 flogross89 added QA A380 Only QA only for A380 required A380X Related to the A380X aircraft labels Jan 6, 2025
@flogross89 flogross89 added this to the v0.13.0 milestone Jan 6, 2025
@flogross89 flogross89 force-pushed the feat-a380x-oans-flags branch from ec3c825 to f334ad1 Compare January 10, 2025 03:52
@flogross89 flogross89 marked this pull request as ready for review January 14, 2025 04:25
@flogross89 flogross89 requested a review from Benjozork January 20, 2025 01:00
# Conflicts:
#	fbw-a380x/src/systems/instruments/src/ND/OansControlPanel.tsx
#	fbw-a380x/src/systems/instruments/src/ND/instrument.tsx
@Benjozork Benjozork added QA Tier 2 ND (Navigation Display) labels Jan 31, 2025
# Conflicts:
#	.github/CHANGELOG.md
#	fbw-a380x/src/systems/instruments/src/ND/OansControlPanel.tsx
@utkrishtm
Copy link

Quality Assurance Tester Report

Discord Username : utkrishtm
Object of testing : #9725
Aircraft : A380X
Tier of Testing : 2
Date : 02/09/2025

Testing Process:

Tested Airport: OMDB by iniBuilds, EHAM by FlyTampa, KJFK by iniBuilds

Issue Fixes:

  • The lubber line is now properly displayed.
    9725_LubberLine

  • The arrow is correctly aligned and pointing in the right direction.

  • Set Plan Mode working as well
    9725_SetPlanMode

Context Menu Functionality:

  • Successfully added individual crosses and flags wherever needed using the context menu.
    9725_ContextMenu

  • When selecting a taxiway and clicking the button to add flags or crosses, multiple crosses and flags are automatically placed along the entire taxiway. This functionality extends to runways as well. The "Center on XXX" option works as expected, including centering on aircraft.
    9725_Flags Crosses
    9725_CenterOnMap

BTV Testing:

  • Selected a taxiway before the dry marker, and the feature performed as expected showing "Exit Missed".
    9725_ExitMissed

OANS Performance Mode:

  • OANS performance mode works. After 60 seconds, it clears all mapped data and reloads the map with a clean view

Circuit Breaker for ARPT NAV:

  • Pulling the circuit breaker for ARPT NAV correctly disables the OANS system.
    9725_ArptNavCircuitBreaker

Testing Results:
Passed

Conclusions:

  • Everything looks really good and functioning as intended. All the changes in the Summary were tested and are working as intended. Great feature to have.

@aadee9940
Copy link

I forgot to comment, Over the last few days I flew a couple flights with this build.

Right before takeoff I pull the ARPT NAV reset and it clears OANS from memory correctly. 10 minutes before TOD I go to set up my BTV, and the OANS is stuck on loading, the airport map never loads. To solve this, I had to relink navigraph.

@utkrishtm did u ever encounter this?

@utkrishtm
Copy link

utkrishtm commented Feb 9, 2025

I forgot to comment, Over the last few days I flew a couple flights with this build.

Right before takeoff I pull the ARPT NAV reset and it clears OANS from memory correctly. 10 minutes before TOD I go to set up my BTV, and the OANS is stuck on loading, the airport map never loads. To solve this, I had to relink navigraph.

@utkrishtm did u ever encounter this?

Yea so the map wouldn't load which is expected as it clears everything out. However if you choose the airport and click on Display Airport, it comes up. Make sure that the circuit breaker for ARPT NAV is clicked in before that. I did not test it the way you are. Try this and if it doesn't work ill test it again with what you did.

@flogross89
Copy link
Contributor Author

I forgot to comment, Over the last few days I flew a couple flights with this build.

Right before takeoff I pull the ARPT NAV reset and it clears OANS from memory correctly. 10 minutes before TOD I go to set up my BTV, and the OANS is stuck on loading, the airport map never loads. To solve this, I had to relink navigraph.

@utkrishtm did u ever encounter this?

Did you load an airport manually, as @utkrishtm described?

@utkrishtm
Copy link

I just tested how @aadee9940 did, and after clicking display airport again, it works fine. No need to relink Navigraph.

@aadee9940
Copy link

aadee9940 commented Feb 9, 2025

@flogross89 @utkrishtm Yep so, when setting up BTV, I go to Plan Mode, zoom in till the OANS GUI pops up, Then going over to ARPT SEL tab, i had my departure and destination airport, KMIA, EGLL. After clicking on display airport for both and waiting upwards of 3-4 minutes, still nothing showed up. Hence stuck on loading.

I did verify the ARPT NAV reset was in and not active.

Another test I did was to simply monitor VRAM usage, when Oans is being used it can use upwards of 800-900mb, which is noticeable in the dev display. When I encountered this bug, the VRAM did not fill up as it was stuck on loading.

After relinking navi, the vram usage went up and oans loaded in properly.

If both of you do not encounter this issue, then something might me up with my navigraph, thats my guess. Sorry for the bother

# Conflicts:
#	.github/CHANGELOG.md
@flogross89 flogross89 enabled auto-merge (squash) February 9, 2025 21:46
@flogross89 flogross89 merged commit c678432 into flybywiresim:master Feb 9, 2025
8 checks passed
@tracernz
Copy link
Member

tracernz commented Feb 10, 2025

* The lubber line is now properly displayed.

9725_LubberLine

That is still not correct FYI @flogross89. It should be above the other stuff.
image
image

@Ueeew
Copy link

Ueeew commented Feb 10, 2025

@flogross89 unfortunately I’ve just noticed that this PR seams to disable the opportunity to use BTV for no Navigraph users. The window where you used to put the brake distance in the past is now greyed out so you can’t insert the distance anymore. It looks like an interface issue to me. If you could fix that it’s would be great. :)

@flogross89
Copy link
Contributor Author

@Ueeew Oh, that's not good. Do you have some more details? Does it disable the field always or "just" when the resets are pulled or performance mode unloaded the map?

@utkrishtm
Copy link

@Ueeew Oh, that's not good. Do you have some more details? Does it disable the field always or "just" when the resets are pulled or performance mode unloaded the map?

I'll redo the test without navigraph. Sorry missed that part

@flogross89
Copy link
Contributor Author

@Ueeew Oh, that's not good. Do you have some more details? Does it disable the field always or "just" when the resets are pulled or performance mode unloaded the map?

I'll redo the test without navigraph. Sorry missed that part

No worries, also didn't think about it when writing the test instructions. Sometimes these things happen with complex functions :)

@utkrishtm
Copy link

utkrishtm commented Feb 10, 2025

* The lubber line is now properly displayed.

9725_LubberLine

That is still not correct FYI @flogross89. It should be above the other stuff. image image

Regarding this, I tested it across a real video of A380 at the same airport. and it looks the same.
Here is the photo for reference (https://youtu.be/yGlS2QBuX7s?si=qiBPcnL5Lq7hUa-E&t=524)
Screenshot 2025-02-10 at 4 32 06 PM

This is what i see in the sim at the same airport WMKK
WMKK LubberLine

Not sure if I am missing anything

@Ueeew
Copy link

Ueeew commented Feb 10, 2025

@Ueeew Oh, that's not good. Do you have some more details? Does it disable the field always or "just" when the resets are pulled or performance mode unloaded the map?

I’ve just made one test flight. I was the last week not at home and when I came back and updated the aircraft BTV didn’t worked anymore. This PR is the only one which really has something to do with OANS and Btv so I assume that there is an issue.

@utkrishtm
Copy link

@Ueeew Oh, that's not good. Do you have some more details? Does it disable the field always or "just" when the resets are pulled or performance mode unloaded the map?

I’ve just made one test flight. I was the last week not at home and when I came back and updated the aircraft BTV didn’t worked anymore. This PR is the only one which really has something to do with OANS and Btv so I assume that there is an issue.

Hey, is this what you see?
9725_BTVNoNavi

@flogross89
Copy link
Contributor Author

@Ueeew Oh, that's not good. Do you have some more details? Does it disable the field always or "just" when the resets are pulled or performance mode unloaded the map?

I’ve just made one test flight. I was the last week not at home and when I came back and updated the aircraft BTV didn’t worked anymore. This PR is the only one which really has something to do with OANS and Btv so I assume that there is an issue.

Hey, is this what you see? 9725_BTVNoNavi

Ahh got it, thank you! I think I found the culprit.

@utkrishtm
Copy link

utkrishtm commented Feb 10, 2025

Actually it is working. I was just able to do it.

9725_BTVNoNaviWorking.mp4

@BravoMike99
Copy link
Contributor

* The lubber line is now properly displayed.

9725_LubberLine
That is still not correct FYI @flogross89. It should be above the other stuff. image image

Regarding this, I tested it across a real video of A380 at the same airport. and it looks the same. Here is the photo for reference (https://youtu.be/yGlS2QBuX7s?si=qiBPcnL5Lq7hUa-E&t=524) Screenshot 2025-02-10 at 4 32 06 PM

This is what i see in the sim at the same airport WMKK WMKK LubberLine

Not sure if I am missing anything

If you look at it closely, in the sim the rubber line is obstructed by/behind the compass while on the real aircraft is not. That's what tracer was referring to

@utkrishtm
Copy link

* The lubber line is now properly displayed.

9725_LubberLine
That is still not correct FYI @flogross89. It should be above the other stuff. image image

Regarding this, I tested it across a real video of A380 at the same airport. and it looks the same. Here is the photo for reference (https://youtu.be/yGlS2QBuX7s?si=qiBPcnL5Lq7hUa-E&t=524) Screenshot 2025-02-10 at 4 32 06 PM
This is what i see in the sim at the same airport WMKK WMKK LubberLine
Not sure if I am missing anything

If you look at it closely, in the sim the rubber line is obstructed by/behind the compass while on the real aircraft is not. That's what tracer was referring to

Ahhh, that makes sense. Thanks!

@flogross89
Copy link
Contributor Author

flogross89 commented Feb 11, 2025

@tracernz @utkrishtm Indeed the ordering of the layers wasn't/is correct for the lubber line and the aircraft symbol. Fixed in #9849

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A380X Related to the A380X aircraft ND (Navigation Display) QA A380 Only QA only for A380 required QA Passed QA Ready to Test QA Tier 2
Projects
Status: ✔️ Done
7 participants