Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fmgc): multiple FMGC fixes and small additions #9652

Merged
merged 7 commits into from
Feb 6, 2025

Conversation

lukecologne
Copy link
Member

@lukecologne lukecologne commented Dec 12, 2024

Fixes #9661

Summary of Changes

This PR adds some small fixes for the FMGC mode logic:

  • Use correct bits for the EXP CLB/DES mode sync, and add EXP bits to the CLB/DES mode sync. This prevents incorrect mode switching or reversions when changing the master FMGC (i.e. AP switching, or FMGC failure) while EXP CLB/DES is engaged.
  • Reset all engaged modes at engine start, to ensure a consistent configuration for takeoff if any modes were engaged when the engines were not yet started.
  • Fix triple click sounding when entering global speed protection (FD auto deactivation), even when no FD was engaged
  • CAT 1 capability is now shown instead of CAT 2 when no RA indicates NO
  • Re-add support for the A32NX_FG_RNAV_APP_SELECTED LVar
  • Fix missing abs() in the NAV capture condition, to prevent immediate NAV activation when having a negative XTK, regardless of the actual distance to the path
  • Raise default RA value (when both RAs are FW) to 2500ft, to enable LOC arming when all RAs are failed

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub):

Testing instructions

  • Check that the fixes listed above work as described (where applicable, i.e. excluding the A32NX_FG_RNAV_APP_SELECTED Lvar)
  • Check that the FG in general works as expected (not a full flight needed, a takeoff/departure and approach should be enough)

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

@lukecologne lukecologne marked this pull request as draft December 21, 2024 18:45
@lukecologne
Copy link
Member Author

Converting to draft as there as some more changes I want to bring in

@lukecologne lukecologne changed the title fix(fmgc): fix mode sync for EXP, add mode reset at engine start fix(fmgc): multiple FMGC fixes and small additions Dec 26, 2024
@lukecologne lukecologne marked this pull request as ready for review December 27, 2024 13:13
@tracernz
Copy link
Member

It would be better to summarise what the fixes are in the title if possible as this is the one we will see when it’s squash merged. fix is already the first word so that’s redundant.

@lukecologne
Copy link
Member Author

It's a bit hard, since they're basically all independent fixes

@lukecologne lukecologne added A32NX Related to the A32NX aircraft QA Tier 1 labels Feb 2, 2025
@tracernz
Copy link
Member

tracernz commented Feb 6, 2025

Dev Team QA report

Discord Username : tracernz
Object of testing : #9652
Aircraft : A32NX
Tier of Testing : 2
Date : 07/02/2025
Testing Process:
Performed a full flight, while testing along the way.

  • Tried EXP CLB, changing APs while in process.
  • Tried capturing NAV from both sides with XTK > 5 NM.
  • Turn off FDs and enter speed protection.
  • Tried EXP DES, changing APs while in process.
  • Fail both RAs on approach and check for CAT I, and ability to arm LOC.

Testing Results:
Passed

@tracernz tracernz enabled auto-merge (squash) February 6, 2025 13:04
@tracernz tracernz merged commit 9cfc51f into flybywiresim:master Feb 6, 2025
8 checks passed
denmax18 added a commit to denmax18/A388x that referenced this pull request Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A32NX Related to the A32NX aircraft QA Passed QA Tier 1
Projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

FG: CAT2 instead of CAT 1 approach capability on PFD without RA signal
2 participants