-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(a380x/flight model): A380X Flight Model Update #9830
base: master
Are you sure you want to change the base?
fix(a380x/flight model): A380X Flight Model Update #9830
Conversation
Takeoff at 410T, Using EFB CG of 40%. Flaps 1+F Takeoff. MSFS24.
Anyways, at takeoff gear up. I pitched all the way up to 30 degrees. Previously if I did this, I would've triggered the bug and there would be no saving it. This time however, plane will happily respond to my inputs. Going further, i entered the amber speed range and activated alpha floor, what is important now is that if i can control the elevators and thus the pitch of the aircraft to recover. This is what the aircraft does with the fix, I was able to fully control the aircraft and recover the plane fully. For now, everything looks good. Great work. Thank you. |
Thanks @aadee9940. I did not expect any testing on this yet, let alone within minutes of building it! I've converted it to draft until someone who can code (which does not include me) can change the CGs shown on the PFD and SD to be the same as that shown on the payload page of the EFB. |
@donstim I have had countless flights diving to the ground after 30 mins of preflight, safe to say this issue is a bit personal hahaha😁 |
Test 2: Takeoff at 448T, EFB CG OF 40.6, FLEX 65, KMIA09, FLAPS 1+F, MSFS24
Edit: Landing into Heathrow was uneventful, everything was nice and stable. I have never encountered issue #9399, so can't say if this affects anything for it. Test 2 results were good, fixes are working. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, excited for this!
Test 3: Takeoff at 394T, CG OF 38.6, FLEX 64, VOBL09L, FLAPS 1+F, MSFS24 Auto-rotate issue: Not observed, nose stayed planted till VR of 151. Stall issue: Not observed, plane was stable and flew well from initial climb till I turned on AP1 at around 4000 AGL. Landing was ok, no issues. I will also start testing the deeper CG/EFB/THS/PFD changes soon. |
Fixes #[issue_no]
Summary of Changes
This PR does essentially the same thing (but accomplishes it differently) as #9728. This was necessary to fix the pitch-up/unrecoverable stall and auto-rotation issues for MSFS 2024 as well as 2020. The fixes contained in #9645 and #9728 only work correctly in MSFS 2020. So this PR supersedes both of those previous PRs.
General update to flight model plus:
Screenshots (if necessary)
References
Additional context
This PR supersedes (and closes #9728). In addition to working with FS2024, the pitch control at takeoff should be better behaved than in that PR relative to the rotation law. The rotation law should still be tuned, but it should be as big an issue as before.
Discord username (if different from GitHub): donbikes
Testing instructions
If you have FS2024, also perform the tests in that sim to confirm the fixes work there as well.
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.