Allow border collapse even on paginated tables. #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging for release later today. It's been ages since I've worked on this, but my recollection is that I just wasn't sure it would work well. Boarding collapsing works by picking a winning border for each side. I think I was worried that some cells would end up with missing border edges. In any case, if it appears to work, I'm happy to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired from danfickle/openhtmltopdf#97, this simply removes an exception from the code and allows border collapse even on paginated tables.
It works and is much better looking / less of an unexpected change in output, at least to me.
(I wonder why that exception was in place in the first place, though)