Skip to content

Commit

Permalink
dockerizing buf call (#356)
Browse files Browse the repository at this point in the history
Signed-off-by: Daniel Rammer <[email protected]>

Signed-off-by: Daniel Rammer <[email protected]>
  • Loading branch information
hamersaw authored Jan 5, 2023
1 parent 943ea2f commit d1ff65f
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions flyteidl/generate_protos.sh
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,7 @@ do
done

# Buf migration
# TODO: fix stub generation via docker image. The trick of forcing the current user as a user in
# the container (used extensively in this file) does not work.
# docker run --volume "$(pwd):/workspace" --workdir /workspace bufbuild/buf generate
buf generate
docker run -u $(id -u):$(id -g) -e "BUF_CACHE_DIR=/tmp/cache" --volume "$(pwd):/workspace" --workdir /workspace bufbuild/buf generate

# Unfortunately the python protoc plugin does not add __init__.py files to the generated code
# (as described in https://github.com/protocolbuffers/protobuf/issues/881). One of the
Expand Down

0 comments on commit d1ff65f

Please sign in to comment.