Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI Feature] Explicitly define content-type as 'application/javascript' for requests to assets/main.js #1735

Closed
2 tasks done
jsonporter opened this issue Oct 21, 2021 · 0 comments · Fixed by flyteorg/flyteconsole#235
Assignees
Labels
enhancement New feature or request ui Admin console user interface
Milestone

Comments

@jsonporter
Copy link

Motivation: Why do you think this is important?

Requests with nosniff will fail when data requested is not the correct MIME type. While this is not an issue in most use cases/users, users behind proxies that add this header will be affected. However, user base aside, this is a best practice that we should implement regardless.

Acceptance Criteria:

  • Requests should explicitly define MIME/content-type; type should be correct.

Goal: What should the final outcome look like, ideally?

MIME type for requests to /assets/main.js are served as application/javascript

Propose: Link/Inline OR Additional context

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ui Admin console user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants