feat: explicitly define content type #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pianist038801 <[email protected]>
Pianist038801
force-pushed
the
feat/explicitly-define-content-type
branch
from
83cd231 to
c3917f0
Compare
Codecov Report
@@ Coverage Diff @@
## master #235 +/- ##
=========================================
Coverage ? 63.45%
=========================================
Files ? 365
Lines ? 7913
Branches ? 1388
=========================================
Hits ? 5021
Misses ? 2892
Partials ? 0 Continue to review full report at Codecov.
|
|
@jsonporter just checking-in here to see if we can get this PR reviewed and merged :). It seems like this is tagged to go out in the 0.18.1 release — any idea when that would be? |
Signed-off-by: Jason Porter <[email protected]>
jsonporter
approved these changes
Nov 16, 2021
flyte-bot
added a commit
that referenced
this pull request
Nov 16, 2021
# [0.31.0](http://github.com/lyft/flyteconsole/compare/v0.30.0...v0.31.0) (2021-11-16) ### Features * explicitly define content type ([#235](http://github.com/lyft/flyteconsole/issues/235)) ([0cbcd13](http://github.com/lyft/flyteconsole/commit/0cbcd134eda192424d59a19bc0f57256e314181d))
|
🎉 This PR is included in version 0.31.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This was referenced Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes MIME type for requests to /assets/main.js served as application/javascript
Type
Are all requirements met?
Tracking Issue
fixes flyteorg/flyte#1735
Follow-up issue
NA