-
Notifications
You must be signed in to change notification settings - Fork 684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core feature] @dynamic
should accept all (?) of @workflow
attributes
#5465
Comments
Currently, the According to this discussion, a workaround is to wrap the dynamic workflow within a static workflow that can accept the For example: from flytekit import workflow, dynamic, WorkflowFailurePolicy
@workflow(failure_policy=WorkflowFailurePolicy.FAIL_AFTER_EXECUTABLE_NODES_COMPLETE)
def top_level_workflow():
dynamic_workflow()
@dynamic
def dynamic_workflow():
# Your dynamic tasks here
pass Would you like more details on this workaround or other potential solutions? Sources: This is an AI-generated response and your feedback is appreciated! Please leave a 👍 if this is helpful and 👎 if it is not. Mention @RunLLM to ask follow-up questions. See runllm.com for more! |
we're investing in extending the list of mappable entities and will not prioritize this feature at the moment. I'll keep the issue open in case someone in the community decides to invest in it. |
@eapolinario your suggestion and @EngHabu's issue are different isnt it? |
Yes, wrapping a dynamic workflow within a static workflow that accepts the Example: from flytekit import workflow, dynamic, WorkflowFailurePolicy
@workflow(failure_policy=WorkflowFailurePolicy.FAIL_AFTER_EXECUTABLE_NODES_COMPLETE)
def top_level_workflow():
dynamic_workflow()
@dynamic
def dynamic_workflow():
# Your dynamic tasks here
pass Would you like more details on this workaround or other potential solutions? Sources: This is an AI-generated response and your feedback is appreciated! Please leave a 👍 if this is helpful and 👎 if it is not. Mention @RunLLM to ask follow-up questions. See runllm.com for more! |
No because the subworkflow the dynamic task creates won't propagate these properties. So it's no use. |
The Would you like more details on this workaround or other potential solutions? Sources: This is an AI-generated response and your feedback is appreciated! Please leave a 👍 if this is helpful and 👎 if it is not. Mention @RunLLM to ask follow-up questions. See runllm.com for more! |
Motivation: Why do you think this is important?
@dynamic
represents a dynamic workflow and should accept all configurations we can pass to a static@workflow
... I was attempting to addfailure_policy
and realized it's not possibleGoal: What should the final outcome look like, ideally?
Not yet sure of the UX.
Maybe just
@dynamic(...failure_policy...
The downside here is that can potentially conflate the task attributes with workflow ones
Maybe
@dynamic(workflow_config=Workflow(failure_policy=....
Describe alternatives you've considered
Map over launchplan. Not supported
Propose: Link/Inline OR Additional context
No response
Are you sure this issue hasn't been raised already?
Have you read the Code of Conduct?
The text was updated successfully, but these errors were encountered: