Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]Generic Type should support JSON Schema association #654

Closed
1 of 13 tasks
kumare3 opened this issue Dec 23, 2020 · 2 comments
Closed
1 of 13 tasks

[Feature]Generic Type should support JSON Schema association #654

kumare3 opened this issue Dec 23, 2020 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@kumare3
Copy link
Contributor

kumare3 commented Dec 23, 2020

Motivation: Why do you think this is important?
Flyte supports JSON types using the Generic Struct attribute. But, it is hard to build an auto-completing UI as well as ensuring type-safety at the time of passing in parameters. Optional JSON schema offers this additional guarantee

Goal: What should the final outcome look like, ideally?
Users can use Launch form, that automatically completes or creates a prototype json object for them based on the json schema. For ensuring this is simple and without a lot of overhead this can be completely optional

Describe alternatives you've considered
None

Flyte component

  • Overall
  • Flyte Setup and Installation scripts
  • Flyte Documentation
  • Flyte communication (slack/email etc)
  • FlytePropeller
  • FlyteIDL (Flyte specification language)
  • Flytekit (Python SDK)
  • FlyteAdmin (Control Plane service)
  • FlytePlugins
  • DataCatalog
  • FlyteStdlib (common libraries)
  • FlyteConsole (UI)
  • Other

Is this a blocker for you to adopt Flyte
NA

@kumare3 kumare3 added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers labels Dec 23, 2020
@kumare3 kumare3 removed the untriaged This issues has not yet been looked at by the Maintainers label Mar 1, 2021
@kumare3 kumare3 added this to the 0.13.0 milestone Mar 1, 2021
@kumare3 kumare3 modified the milestones: 0.13.0, 0.14.0 May 5, 2021
@kumare3 kumare3 modified the milestones: 0.14.0, 0.15.0 Jun 2, 2021
@EngHabu
Copy link
Contributor

EngHabu commented Jul 7, 2021

What's the end goal of this? should it be closed when we have it in the UI?

@EngHabu EngHabu modified the milestones: 0.15.0, 0.16.0 Jul 7, 2021
@kumare3
Copy link
Contributor Author

kumare3 commented Jul 7, 2021

@EngHabu I think the UI part should be a separate task. Let me create one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants