Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI Feature] Generic JSON schema validation in Flyteconsole launch forms #1216

Closed
kumare3 opened this issue Jul 7, 2021 · 3 comments · Fixed by flyteorg/flyteconsole#186
Closed
Assignees
Labels
enhancement New feature or request ui Admin console user interface
Milestone

Comments

@kumare3
Copy link
Contributor

kumare3 commented Jul 7, 2021

Motivation: Why do you think this is important?
Related to - #654
Now that Generic Structs can have Schema associated with them optionally, it would be useful for the users of FlyteConsole - LaunchForm to launch an execution where for structure types, the UX is auto-generated

An ideal example for the UX could be to follow the VS code style - type-ahead JSON editor as shown here
OR
an auto-generating form like here

This makes the users like extremely easy to structured data. This is extremely useful for Hyper parameter tuning, node-code tasks, configuration etc

Example for workflow in flytesnacks https://github.com/flyteorg/flytesnacks/blob/master/cookbook/core/type_system/custom_objects.py

Goal: What should the final outcome look like, ideally?
Users should be able to enter valid json instead of arbitrary json

[Optional] Propose: Link/Inline OR Additional context AND/OR Mock ideas
[WIP]

@kumare3 kumare3 added enhancement New feature or request ui Admin console user interface untriaged This issues has not yet been looked at by the Maintainers and removed untriaged This issues has not yet been looked at by the Maintainers labels Jul 7, 2021
@kumare3 kumare3 added this to the 0.16.0 milestone Jul 7, 2021
@kumare3 kumare3 changed the title [UI Feature] [UI Feature] Generic JSON schema validation in Flyteconsole launch forms Jul 7, 2021
@kumare3
Copy link
Contributor Author

kumare3 commented Jul 13, 2021

I think another approach would be to use YAML as the representation instead of json and use a library like https://github.com/redhat-developer/yaml-language-server

@kumare3
Copy link
Contributor Author

kumare3 commented Jul 13, 2021

cc @jsonporter would love your inputs on this

@kumare3
Copy link
Contributor Author

kumare3 commented Jul 20, 2021

@jsonporter the doc for the json-schema update can be found here.

In short the schema for a json value is optional. But, when it is available it will be in a standardized jsonschema format (a closure with all entities described in the same schema). The schema is available in the LiteralType.metadata field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ui Admin console user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants