Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG][UI] Oversized error message shown when failing to fetch task details #673

Closed
1 of 13 tasks
schottra opened this issue Jan 15, 2021 · 1 comment
Closed
1 of 13 tasks

[BUG][UI] Oversized error message shown when failing to fetch task details #673

schottra opened this issue Jan 15, 2021 · 1 comment
Assignees
@schottra
Labels
bug Something isn't working ui Admin console user interface untriaged This issues has not yet been looked at by the Maintainers

Comments

@schottra
Copy link
Contributor

Describe the bug
When failing to fetch task details for a NodeExecution in the table, we show a large NotFound error for all components which consume the value via WaitForQuery.

Expected behavior
Some type of fallback text.

Flyte component

  • Overall
  • Flyte Setup and Installation scripts
  • Flyte Documentation
  • Flyte communication (slack/email etc)
  • FlytePropeller
  • FlyteIDL (Flyte specification language)
  • Flytekit (Python SDK)
  • FlyteAdmin (Control Plane service)
  • FlytePlugins
  • DataCatalog
  • FlyteStdlib (common libraries)
  • FlyteConsole (UI)
  • Other

Screenshots
image
@schottra schottra added bug Something isn't working ui Admin console user interface untriaged This issues has not yet been looked at by the Maintainers labels Jan 15, 2021
@schottra schottra self-assigned this Jan 15, 2021
@schottra schottra mentioned this issue Jan 15, 2021
Merged
@schottra
Copy link
Contributor Author

fixed by flyteorg/flyteconsole#146
available in flyteconsole v0.19.4

palchicz pushed a commit to palchicz/flyte that referenced this issue Dec 23, 2021
@hamersaw
Add cache_serialize parameter to tasks (flyteorg#673)
37814ae 
* added cache_serialize parameter for basic tasks

Signed-off-by: Daniel Rammer <[email protected]>

* fixed typo

Signed-off-by: Daniel Rammer <[email protected]>

* updated flyteidl version

Signed-off-by: Daniel Rammer <[email protected]>

* changed flyteidl requirements everywhere

Signed-off-by: Daniel Rammer <[email protected]>

* remove flyteidl version requires in setup.py so we can use develop

Signed-off-by: Daniel Rammer <[email protected]>

* removed flyteidl git repos from a variety of requirements packages

Signed-off-by: Daniel Rammer <[email protected]>

* updated variable discovery_serializable to cache_serializable

Signed-off-by: Daniel Rammer <[email protected]>

* updated requirements

Signed-off-by: Daniel Rammer <[email protected]>

* fixed TaskMetadata _cache_serializable variable name

Signed-off-by: Daniel Rammer <[email protected]>

* propgating cache_serialize parameter through to tasks

Signed-off-by: Daniel Rammer <[email protected]>

* added cache_serializable to SdkRawContainerTask

Signed-off-by: Daniel Rammer <[email protected]>

* fixing cache_serializable variable propogation issues

Signed-off-by: Daniel Rammer <[email protected]>

* added documentation

Signed-off-by: Daniel Rammer <[email protected]>

* added unit tests for cache_serialize metadata

Signed-off-by: Daniel Rammer <[email protected]>

* linter added spaces in unit tests

Signed-off-by: Daniel Rammer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schottra schottra

Labels
bug Something isn't working ui Admin console user interface untriaged This issues has not yet been looked at by the Maintainers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@schottra