Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] "View Input and Output" UI doesn't correctly show parameters #909

Closed
PhoenixLiAtLyft opened this issue Apr 13, 2021 · 2 comments · Fixed by flyteorg/flyteconsole#206
Closed

[BUG] "View Input and Output" UI doesn't correctly show parameters #909

PhoenixLiAtLyft opened this issue Apr 13, 2021 · 2 comments · Fixed by flyteorg/flyteconsole#206
Assignees
@Pianist038801 @jsonporter
Labels
bug Something isn't working ui Admin console user interface
Milestone
0.18.0

Comments

@PhoenixLiAtLyft
Copy link

PhoenixLiAtLyft commented Apr 13, 2021 •
edited
Loading

Describe the bug
Hi Team, we noticed that sometimes if you open "View Inputs & Outputs" UI, it doesn't show the same parameters exactly as your input. For example, in my attached screenshot, we accidentally added an extra space before "turn_features". But in the "View Inputs & Outputs" UI there is no extra space. We only found it when we opened "Relaunch" UI.
Can you fix it? I believe it will help all flyte users to debug if they accidentally added a space in their input.

Expected behavior
The "View Inputs & Outputs" UI should also show the extra space

[Optional] Additional context
To Reproduce
Steps to reproduce the behavior:

  1. Choose any workflow. Give an extra space in one of the input and launch it
  2. Open "View Inputs & Outputs" and you won't see the extra space

Screenshots
Screen Shot 2021-04-13 at 10 25 30 AM
Screen Shot 2021-04-13 at 10 27 27 AM
@PhoenixLiAtLyft PhoenixLiAtLyft added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels Apr 13, 2021
@kumare3 kumare3 removed the untriaged This issues has not yet been looked at by the Maintainers label Apr 13, 2021
@kumare3 kumare3 added this to the 0.15.0 milestone Jun 7, 2021
@kumare3
Copy link
Contributor

kumare3 commented Jun 7, 2021

@jsonporter in your copious free time

@kumare3 kumare3 modified the milestones: 0.15.0, 0.16.0 Jul 3, 2021
@EngHabu EngHabu modified the milestones: 0.16.0, 0.17.0 Aug 2, 2021
@EngHabu EngHabu added ui Admin console user interface bugSquash-Cascade labels Aug 30, 2021
@EngHabu EngHabu modified the milestones: 0.17.0, 0.18.0 Aug 31, 2021
@jsonporter
Copy link

Hey @PhoenixLiAtLyft - thinking through this bug, I think the right move would be to stop this at the source and add validation on the input to ensure no leading/trailing whitespace. Does that sound good to you?

@Pianist038801 Pianist038801 mentioned this issue Sep 20, 2021
Merged
8 tasks
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@pingsutw
Fix broken link (flyteorg#909)
350bc84 
Signed-off-by: Kevin Su <[email protected]>

Signed-off-by: Kevin Su <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pianist038801 Pianist038801

@jsonporter jsonporter

Labels
bug Something isn't working ui Admin console user interface
Projects
None yet
Milestone
0.18.0
Development

Successfully merging a pull request may close this issue.

fix: ensure no leading or trailing whitespace on the string input flyteorg/flyteconsole
5 participants
@EngHabu @kumare3 @Pianist038801 @PhoenixLiAtLyft @jsonporter