fix pod template override error #6224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nelson Chen <[email protected]>
Code Review Agent Run #bbe101Actionable Suggestions - 1
Review Details
AI Code Review powered by |
Changelist by BitoThis pull request implements the following key changes.
|
flyte-bot
reviewed
Feb 6, 2025
| @@ -289,7 +289,7 @@ func BuildRawPod(ctx context.Context, tCtx pluginsCore.TaskExecutionContext) (*v | |||
|
|
|||
| // handle pod template override | |||
| podTemplate := tCtx.TaskExecutionMetadata().GetOverrides().GetPodTemplate() | |||
| if tCtx.TaskExecutionMetadata().GetOverrides().GetPodTemplate() != nil { | |||
| if podTemplate.GetPodSpec() != nil { | |||
There was a problem hiding this comment.
Potential nil pointer dereference in podTemplate
Consider checking if podTemplate is not nil before accessing its methods. The current code could panic if podTemplate is nil.
Code suggestion
Check the AI-generated fix before applying
Suggested change
| if podTemplate.GetPodSpec() != nil { | |
| if podTemplate != nil && podTemplate.GetPodSpec() != nil { |
Code Review Run #bbe101
Is this a valid issue, or was it incorrectly flagged by the Agent?
- it was incorrectly flagged
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6224 +/- ##
=======================================
Coverage 36.85% 36.86%
=======================================
Files 1318 1318
Lines 134534 134534
=======================================
+ Hits 49586 49592 +6
+ Misses 80627 80621 -6
Partials 4321 4321
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Future-Outlier
approved these changes
Feb 6, 2025
Future-Outlier
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
#5683
Why are the changes needed?
An error occurs when running a workflow because of this error.
Workflow[flytesnacks:development:dynamic.dynamic_wf] failed. RuntimeExecutionError: max number of system retry attempts [11/10] exhausted. Last known status message: failed at Node[n0]. RuntimeExecutionError: failed during plugin execution, caused by: failed to execute handle for plugin [container]: nil Struct Object passed
What changes were proposed in this pull request?
Accessing PodTemplate correctly.
How was this patch tested?
Labels
Please add one or more of the following labels to categorize your PR:
This is important to improve the readability of release notes.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link
Summary by Bito
This PR addresses a critical workflow execution error by implementing proper pod template validation. The fix modifies pod helper logic to ensure safe PodSpec access, preventing system retry exhaustion errors. The change introduces additional nil checks to prevent potential crashes.Unit tests added: False
Estimated effort to review (1-5, lower is better): 1