Return NotFound error when decks uri is empty (#642) #6228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmahindrakar-oss
changed the title
Code Review Agent Run #b1cb17Actionable Suggestions - 3
Review Details
AI Code Review powered by |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6228 +/- ##
=======================================
Coverage 36.86% 36.86%
=======================================
Files 1318 1318
Lines 134530 134543 +13
=======================================
+ Hits 49591 49596 +5
- Misses 80619 80626 +7
- Partials 4320 4321 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Changelist by BitoThis pull request implements the following key changes.
|
flyte-bot
reviewed
Feb 6, 2025
Comment on lines
+202
to
+204
| s, dependencies := setupCreateDownloadLink(t) | ||
| dependencies.nodeExecutionManager.EXPECT().GetNodeExecution(mock.Anything, mock.Anything).RunAndReturn(nodeExecutionFunc) | ||
| _, err := s.CreateDownloadLink(context.Background(), &service.CreateDownloadLinkRequest{ |
There was a problem hiding this comment.
Consider consolidating duplicate test setup code
Consider consolidating the duplicate setup code. The setupCreateDownloadLink() call appears multiple times in the test function which could be refactored to improve maintainability.
Code suggestion
Check the AI-generated fix before applying
- s, dependencies := setupCreateDownloadLink(t)
- dependencies.nodeExecutionManager.EXPECT().GetNodeExecution(mock.Anything, mock.Anything).RunAndReturn(nodeExecutionFunc)
- _, err := s.CreateDownloadLink(context.Background(), &service.CreateDownloadLinkRequest{
-
- s, dependencies := setupCreateDownloadLink(t)
- dependencies.dataStore.ComposedProtobufStore.(*commonMocks.TestDataStore).HeadCb = func(ctx context.Context, ref storage.DataReference) (storage.Metadata, error) {
+ setupAndRunTest := func(t *testing.T, setupFn func(*CreateDownloadLinkDependencies)) error {
+ s, dependencies := setupCreateDownloadLink(t)
+ setupFn(dependencies)
+ return s.CreateDownloadLink(context.Background(), &service.CreateDownloadLinkRequest{})
+ }
Code Review Run #b1cb17
Is this a valid issue, or was it incorrectly flagged by the Agent?
- it was incorrectly flagged
flyte-bot
reviewed
Feb 6, 2025
|
|
||
| _, err = s.CreateDownloadLink(context.Background(), &service.CreateDownloadLinkRequest{ | ||
| dependencies.nodeExecutionManager.EXPECT().GetNodeExecution(mock.Anything, mock.Anything).RunAndReturn(nodeExecutionFunc) | ||
| _, err := s.CreateDownloadLink(context.Background(), &service.CreateDownloadLinkRequest{ |
There was a problem hiding this comment.
Variable shadowing in CreateDownloadLink test
Consider declaring err in the first usage to avoid shadowing. The current declaration of err shadows the outer scope variable.
Code suggestion
Check the AI-generated fix before applying
Suggested change
| _, err := s.CreateDownloadLink(context.Background(), &service.CreateDownloadLinkRequest{ | |
| _, err = s.CreateDownloadLink(context.Background(), &service.CreateDownloadLinkRequest{ |
Code Review Run #b1cb17
Is this a valid issue, or was it incorrectly flagged by the Agent?
- it was incorrectly flagged
flyte-bot
reviewed
Feb 6, 2025
| @@ -179,7 +179,7 @@ func (s Service) CreateDownloadLink(ctx context.Context, req *service.CreateDown | |||
| } | |||
|
|
|||
| if len(nativeURL) == 0 { | |||
| return nil, errors.NewFlyteAdminErrorf(codes.Internal, "no deckUrl found for request [%+v]", req) | |||
| return nil, errors.NewFlyteAdminErrorf(codes.NotFound, "no deckUrl found for request [%+v]", req) | |||
There was a problem hiding this comment.
Error code change may mask issues
Consider if changing error code from Internal to NotFound is appropriate here. The NotFound error code should only be used when we're certain the resource doesn't exist. In this case, an empty deckUrl could indicate an internal system issue rather than a missing resource.
Code suggestion
Check the AI-generated fix before applying
Suggested change
| return nil, errors.NewFlyteAdminErrorf(codes.NotFound, "no deckUrl found for request [%+v]", req) | |
| return nil, errors.NewFlyteAdminErrorf(codes.Internal, "no deckUrl found for request [%+v]", req) |
Code Review Run #b1cb17
Is this a valid issue, or was it incorrectly flagged by the Agent?
- it was incorrectly flagged
A deck url not found in node closure shouldn't result in an internal error and instead should return NotFound grpc code Tested by verifying the UI calls are no longer returning 500 and instead returning 404 Merge the correponding cloud pr and rollout to all managed clusters - [x] To be upstreamed to OSS COR-2803 * [ ] Added tests * [ ] Ran a deploy dry run and shared the terraform plan * [ ] Added logging and metrics * [ ] Updated [dashboards](https://unionai.grafana.net/dashboards) and [alerts](https://unionai.grafana.net/alerting/list) * [ ] Updated documentation Signed-off-by: pmahindrakar-oss <[email protected]>
pmahindrakar-oss
force-pushed
the
union/upstream-c2ba613c57d13ff48cf3aa4d331cd055511c7e17
branch
from
090c228 to
f80b0dc
Compare
Code Review Agent Run #74578bActionable Suggestions - 0Review Details
AI Code Review powered by |
pmahindrakar-oss
deleted the
union/upstream-c2ba613c57d13ff48cf3aa4d331cd055511c7e17
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
A deck url not found in node closure shouldn't result in an internal error and instead should return NotFound grpc code
What changes were proposed in this pull request?
Changing the returned grpc code for the API
How was this patch tested?
Tested by verifying the UI calls are no longer returning 500 and instead returning 404
Summary by Bito
The PR implements improved error handling in the data proxy service, changing error codes from Internal to NotFound for missing deck URLs. The test suite underwent significant refactoring with the introduction of CreateDownloadLinkDependencies struct and setup function. Additional test cases were implemented to validate error code behavior for empty deck URLs.Unit tests added: True
Estimated effort to review (1-5, lower is better): 2