chore: fix some function names in comment #6230
Open
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
Signed-off-by: sjtucoder <[email protected]>
Code Review Agent Run #c4c7d0Actionable Suggestions - 0Review Details
AI Code Review powered by |
Changelist by BitoThis pull request implements the following key changes.
|
Code Review Agent Run #c80caeActionable Suggestions - 0Review Details
AI Code Review powered by |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6230 +/- ##
=======================================
Coverage 36.85% 36.86%
=======================================
Files 1318 1318
Lines 134543 134543
=======================================
+ Hits 49590 49597 +7
+ Misses 80632 80625 -7
Partials 4321 4321
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -501,7 +501,7 @@ func (m *MetricsManager) parseNodeExecutions(ctx context.Context, nodeExecutions | |||
| return nil | |||
| } | |||
|
|
|||
| // parseSubworkflowNodeExecutions partitions the SubworkflowNode execution into a collection of Categorical and | |||
| // parseSubworkflowNodeExecution partitions the SubworkflowNode execution into a collection of Categorical and | |||
There was a problem hiding this comment.
Thank you @sjtucoder
Not sure I get the motivation for doing this, and I'm not clear on the effects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Why are the changes needed?
fix some function names in comment
What changes were proposed in this pull request?
How was this patch tested?
Labels
Please add one or more of the following labels to categorize your PR:
This is important to improve the readability of release notes.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link
Summary by Bito
Documentation improvements across multiple files, focusing on function name corrections in comments. Updates include changing plural to singular form for parse functions in metrics_manager.go and fixing casing in subtask_exec_context.go for NewSubTaskExecutionContext comment.Unit tests added: False
Estimated effort to review (1-5, lower is better): 1