Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][flyteagent][test] Default Plugin Config #6239

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mao3267
Copy link
Contributor

@mao3267 mao3267 commented Feb 11, 2025

Tracking issue

#3936

Why are the changes needed?

We aim to enhance the default configuration by adding more customization options for agent users. Specifically, we are introducing custom agent deployments in AgentDeployments and defining task types for specific agents in AgentForTaskTypes. These additions enable greater flexibility across various scenarios.

What changes were proposed in this pull request?

  1. Add AgentDeployments and AgentForTaskTypes in default config
  2. Test the correctness of the default configuration content and verify the task type-to-agent matching.

How was this patch tested?

  1. Modify the existing test to check new added labels (AgentDeployments, AgentForTaskTypes)
  2. Add new test to check matching between task types and agents.

Labels

added

Setup process

git clone https://github.com/flyteorg/flyte.git
gh pr checkout 6239

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

#6179

Docs link

None

@flyte-bot
Copy link
Collaborator

Code Review Agent Run Status

  • Limitations and other issues: ❌ Failure - The AI Code Review Agent skipped reviewing this change because it is configured to exclude certain pull requests based on the source/target branch or the pull request status. You can change the settings here, or contact the agent instance creator at [email protected].

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.87%. Comparing base (34205dd) to head (73afbee).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6239   +/-   ##
=======================================
  Coverage   36.87%   36.87%           
=======================================
  Files        1318     1318           
  Lines      134647   134647           
=======================================
+ Hits        49647    49648    +1     
+ Misses      80679    80678    -1     
  Partials     4321     4321           
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin 51.96% <ø> (ø)
unittests-flytecopilot 30.99% <ø> (ø)
unittests-flytectl 62.29% <ø> (ø)
unittests-flyteidl 7.22% <ø> (ø)
unittests-flyteplugins 54.02% <ø> (ø)
unittests-flytepropeller 42.78% <ø> (ø)
unittests-flytestdlib 55.35% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants