This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Update propeller run to completion #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EngHabu
requested review from
anandswaminathan,
katrogan,
kumare3,
matthewphsmith and
wild-endeavor
as code owners
katrogan
reviewed
Jun 12, 2020
Codecov Report
@@ Coverage Diff @@
## master #102 +/- ##
=======================================
Coverage 63.24% 63.24%
=======================================
Files 101 101
Lines 7465 7465
=======================================
Hits 4721 4721
Misses 2197 2197
Partials 547 547 Continue to review full report at Codecov.
|
katrogan
approved these changes
Jun 18, 2020
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
* Update Propeller to use Run To Completion * Update propeller again * really update propeller * Update propeller * update propeller * revert propeller * update propeller * Update propeller
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Update propeller to consume the new compiler that fills in OnFailurePolicy to enable Run To Completion.
Type
Are all requirements met?
Tracking Issue
flyteorg/flyte#191