Skip to content
This repository was archived by the owner on Oct 9, 2023. It is now read-only.

Fix archive.replacements in goreleaser #586

Merged
merged 2 commits into from
Jul 7, 2023

Conversation

eapolinario
Copy link
Contributor

TL;DR

Similar to flyteorg/flytepropeller#586

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Same fix as flyteorg/flytepropeller#586.

Tracking Issue

Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue

fixes https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

Signed-off-by: eduardo apolinario <[email protected]>
Co-authored-by: Jeev B <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #586 (298a3f3) into master (53282fe) will increase coverage by 1.50%.
The diff coverage is n/a.

❗ Current head 298a3f3 differs from pull request most recent head 51d326c. Consider uploading reports for the commit 51d326c to get more accurate results

@@            Coverage Diff             @@
##           master     #586      +/-   ##
==========================================
+ Coverage   58.62%   60.12%   +1.50%     
==========================================
  Files         168      168              
  Lines       16262    13293    -2969     
==========================================
- Hits         9533     7993    -1540     
+ Misses       5887     4458    -1429     
  Partials      842      842              
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 155 files with indirect coverage changes

@eapolinario eapolinario enabled auto-merge (squash) July 6, 2023 01:58
@eapolinario eapolinario merged commit 05981db into master Jul 7, 2023
@eapolinario eapolinario deleted the fix-replacements-in-goreleaser branch July 7, 2023 13:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants