This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
Revamp Security context to be more specific and expose it to task templates #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumare3
reviewed
Mar 4, 2021
kumare3
reviewed
Mar 4, 2021
kumare3
reviewed
Mar 4, 2021
EngHabu
changed the title
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Co-authored-by: Ketan Umare <[email protected]> Signed-off-by: Haytham Abuelfutuh <[email protected]>
Co-authored-by: Ketan Umare <[email protected]> Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
EngHabu
force-pushed
the
security-context
branch
from
8be294a to
22dee3d
Compare
Signed-off-by: Haytham Abuelfutuh <[email protected]>
EngHabu
force-pushed
the
security-context
branch
from
ca1368f to
9d1c4ce
Compare
kumare3
approved these changes
Mar 5, 2021
8 tasks
eapolinario
pushed a commit
that referenced
this pull request
Sep 8, 2023
…plates (#108) * Revamp Security Context Message Signed-off-by: Haytham Abuelfutuh <[email protected]> * Security Context in Admin entities Signed-off-by: Haytham Abuelfutuh <[email protected]> * fix tabs Signed-off-by: Haytham Abuelfutuh <[email protected]> * add deprecated message Signed-off-by: Haytham Abuelfutuh <[email protected]> * Update protos/flyteidl/core/types.proto Co-authored-by: Ketan Umare <[email protected]> Signed-off-by: Haytham Abuelfutuh <[email protected]> * Update protos/flyteidl/core/types.proto Co-authored-by: Ketan Umare <[email protected]> Signed-off-by: Haytham Abuelfutuh <[email protected]> * Move to security proto Signed-off-by: Haytham Abuelfutuh <[email protected]> * comment Signed-off-by: Haytham Abuelfutuh <[email protected]> * PR Comments Signed-off-by: Haytham Abuelfutuh <[email protected]> Co-authored-by: Ketan Umare <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Introduce SecurityContext message at TaskTemplate, LaunchPlan and Execution levels to allow customization of security attributes; the identity to run as, the secrets to get access to, the tokens to issue...
Type
Tracking Issue
flyteorg/flyte#800