Skip to content
This repository has been archived by the owner on Oct 23, 2023. It is now read-only.

Add aborting workflow execution phase #245

Merged
merged 2 commits into from
Jan 5, 2022
Merged

Add aborting workflow execution phase #245

merged 2 commits into from
Jan 5, 2022

Conversation

katrogan
Copy link
Contributor

@katrogan katrogan commented Jan 4, 2022

Signed-off-by: Katrina Rogan [email protected]

TL;DR

The call to abort a workflow execution results in a two stage process

  1. Flyteadmin deletes the workflow CRD and saves the user-provided abort cause (but not phase) in the db
  2. Flytepropeller detects the workflow CRD has been deleted and sends and abort event, at which point the execution phase is changed

This is confusing for end users when a delay occurs between (1) and (2). Introducing 'ABORTING' allows us to update the execution phase immediately when handling an abort call, providing a better user experience

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

flyteorg/flyte#1978

Follow-up issue

NA

Signed-off-by: Katrina Rogan <[email protected]>
@katrogan katrogan requested a review from EngHabu January 4, 2022 22:30
@katrogan katrogan merged commit fceab47 into master Jan 5, 2022
@katrogan katrogan deleted the terminating branch January 5, 2022 16:45
eapolinario pushed a commit that referenced this pull request Sep 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants