-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Override requests and limits in kwargs with values from task_config #419
Conversation
As done in kftensorflow in flyteorg#408 Signed-off-by: Sören Brunk <[email protected]>
0a01214
to
49ad0a7
Compare
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
Codecov Report
@@ Coverage Diff @@
## master #419 +/- ##
=======================================
Coverage 83.98% 83.98%
=======================================
Files 337 337
Lines 24955 24955
Branches 2028 2028
=======================================
Hits 20959 20959
Misses 3441 3441
Partials 555 555 Continue to review full report at Codecov.
|
…lyteorg#419) As done in kftensorflow in flyteorg#408 Signed-off-by: Sören Brunk <[email protected]>
As done in kftensorflow in #408
TL;DR
Please replace this text with a description of what this PR accomplishes.
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
https://github.com/lyft/flyte/issues/