Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept auth role arg in single task execution #432

Merged
merged 4 commits into from
Mar 25, 2021
Merged

Conversation

katrogan
Copy link
Contributor

TL;DR

Accept auth role arg in single task execution. This is a required param for single task executions but currently can only be set from the user flytekit config.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Also bump flyteidl version to pick up the fix for a non-backwards compatible field number change for auth roles.

Tracking Issue

flyteorg/flyte#860

Follow-up issue

NA

Katrina Rogan and others added 3 commits March 25, 2021 09:44
Signed-off-by: Katrina Rogan <[email protected]>
@codecov
Copy link

codecov bot commented Mar 25, 2021

Codecov Report

Merging #432 (eaa703f) into master (3f57a06) will decrease coverage by 0.02%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #432      +/-   ##
==========================================
- Coverage   84.19%   84.17%   -0.03%     
==========================================
  Files         338      338              
  Lines       25450    25460      +10     
  Branches     2089     2093       +4     
==========================================
+ Hits        21428    21430       +2     
- Misses       3449     3457       +8     
  Partials      573      573              
Impacted Files Coverage Δ
flytekit/common/launch_plan.py 69.36% <ø> (ø)
flytekit/common/mixins/launchable.py 70.58% <ø> (ø)
flytekit/common/tasks/task.py 62.50% <0.00%> (-0.40%) ⬇️
flytekit/clis/flyte_cli/main.py 43.61% <27.27%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f57a06...eaa703f. Read the comment docs.

@wild-endeavor
Copy link
Contributor

How was this working in the past? I know we've tested this before.

@katrogan
Copy link
Contributor Author

you could (and still can) set the auth role in the flytekit config (or with env vars)

@katrogan katrogan merged commit 0396d23 into master Mar 25, 2021
max-hoffman pushed a commit to dolthub/flytekit that referenced this pull request May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants