This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
feat; catalog api update to return additional information for catalog #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #105 +/- ##
==========================================
- Coverage 59.74% 59.52% -0.23%
==========================================
Files 95 95
Lines 5334 5354 +20
==========================================
Hits 3187 3187
- Misses 1845 1865 +20
Partials 302 302
Continue to review full report at Codecov.
|
wild-endeavor
approved these changes
Jul 28, 2020
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
…#105) * Updating Core catalog api to return more information to the engine * use latest * Go modules update * lint fixed * FlyteIDL updated v0.17.38
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
CacheStatus & Catalog Metadata is returned as part of Catalog Addition and Catalog retrieval
Type
Are all requirements met?
Complete description
Prior to this PR, Catalog GET/PUT would only retrieve status of the PUT and in case of GET return previous outputs. This change makes it possible to retrieve associated metadata about the GET/PUT so that we can actually create the lineage information
Tracking Issue
flyteorg/flyte#138
Follow-up issue
NA