Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

#minor Spark and all pods in Flyte can now have global DNS config #235

Merged
merged 1 commit into from
Feb 2, 2022

Conversation

akumor
Copy link
Contributor

@akumor akumor commented Jan 22, 2022

TL;DR

This PR adds a new flag that can allow admins to configure DNS for pods launched by Flyte.
This should be superseded by - flyteorg/flyte#2069

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

NA

@welcome
Copy link

welcome bot commented Jan 22, 2022

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

@akumor akumor force-pushed the add-default-dns-config branch from 11ac19d to 2a0a4ec Compare January 22, 2022 17:58
@akumor akumor marked this pull request as ready for review January 22, 2022 18:02
@codecov
Copy link

codecov bot commented Jan 22, 2022

Codecov Report

Merging #235 (6f7516e) into master (590813b) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #235      +/-   ##
==========================================
+ Coverage   62.42%   62.44%   +0.01%     
==========================================
  Files         142      142              
  Lines        8833     8837       +4     
==========================================
+ Hits         5514     5518       +4     
  Misses       2819     2819              
  Partials      500      500              
Flag Coverage Δ
unittests 62.06% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
go/tasks/pluginmachinery/flytek8s/config/config.go 50.00% <ø> (ø)
go/tasks/pluginmachinery/flytek8s/pod_helper.go 76.64% <100.00%> (+0.23%) ⬆️
go/tasks/plugins/k8s/spark/spark.go 78.54% <100.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 590813b...6f7516e. Read the comment docs.

@akumor akumor force-pushed the add-default-dns-config branch from 2a0a4ec to 6f7516e Compare January 22, 2022 18:40
@EngHabu EngHabu merged commit 6b72fd6 into flyteorg:master Feb 2, 2022
@welcome
Copy link

welcome bot commented Feb 2, 2022

Congrats on merging your first pull request! 🎉

eapolinario pushed a commit that referenced this pull request Sep 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants