This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
[BUG] The primaryContainerName of podtemplate tasks is not overrode with kubeflow specific name #340
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Please replace this text with a description of what this PR accomplishes.
The primaryContainerName of podtemplate tasks is not overrode with kubeflow specific name
Type
Are all requirements met?
Complete description
In the previous implementation, we assumed all tasks are container task, so we used
taskCtx.TaskExecutionMetadata().GetTaskExecutionID().GetGeneratedName()
to get the primary container name. However, in the case of pod template, the primary container name can vary.The solution is to expose primaryContainerName from
ToK8sPodSpec
and pass toOverridePrimaryContainerName
(which was namedOverrideDefaultContainerName)
.Tracking Issue
flyteorg/flyte#3567