This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Bump flytestdlib to v0.4.4 #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Su <[email protected]>
pingsutw
force-pushed
the
updated-stdlib
branch
from
7de6087 to
f9f25c4
Compare
EngHabu
reviewed
Nov 10, 2021
Makefile
Outdated
| @@ -17,7 +17,7 @@ linux_compile: | |||
| .PHONY: compile | |||
| compile: | |||
| mkdir -p ./bin | |||
| go build -o bin/flytepropeller ./cmd/controller/main.go | |||
| go build -o bin/flytepropeller ./cmd/controller/main.go && cp bin/flytepropeller ${GOPATH}/bin | |||
There was a problem hiding this comment.
Let's revert this... if you want, you can add an install Makefile target... and if so it should do go install... let's not make assumptions about where the go bin will be...
Signed-off-by: Kevin Su <[email protected]>
EngHabu
approved these changes
Nov 10, 2021
eapolinario
pushed a commit
to eapolinario/flytepropeller
that referenced
this pull request
Aug 9, 2023
* Updated stdlib version Signed-off-by: Kevin Su <[email protected]> * Revert Makefile Signed-off-by: Kevin Su <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kevin Su [email protected]
TL;DR
update flytestdlib version to support docs generate command (
flytepropeller config docs)https://github.com/flyteorg/flytestdlib/releases/tag/v0.4.4
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue
Follow-up issue
NA