Redesign JNI library rules #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
redesign-java-native-library
branch
5 times, most recently
from
c51c8e5 to
39c5835
Compare
Replace the "magic" circular dependency resolution with an implicit output target "<name>.hdrs" on java_library_with_native and use a more consistent naming scheme for rules. Along the way, fix the incorrect platform reset behavior for jni.h when dependend on through java_native_headers (now jni_headers).
fmeum
force-pushed
the
redesign-java-native-library
branch
from
39c5835 to
ec6eebb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the "magic" circular dependency resolution with an implicit
output target ".hdrs" on java_library_with_native and use a more
consistent naming scheme for rules.
Along the way, fix the incorrect platform reset behavior for jni.h
when dependend on through java_native_headers (now jni_headers).