Prevent loading native libraries with same basename #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
fix-loading-twice
branch
2 times, most recently
from
1d5e00e to
f4e77df
Compare
Loading the same library (identified by its resource path) twice should succeed, but the second load should be a no-op so that static initializers and JNI_OnLoad aren't run twice. Loading two libraries sharing a basename from different paths should result in an error as this situation is not handled consistently by all operating systems and determining whether two libraries are truly identical for all purposes is difficult.
fmeum
force-pushed
the
fix-loading-twice
branch
from
f4e77df to
a044fbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.