Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fmi avi messageconverter iwxxm #80 #81

Merged
merged 12 commits into from
Jun 23, 2021
Merged

Fmi avi messageconverter iwxxm #80 #81

merged 12 commits into from
Jun 23, 2021

Conversation

patrick-alaspaa
Copy link
Contributor

This pull request adresses the issue brought up in issue #80
Add IWXXM 3 parsing to generic bulletin scanner

@patrick-alaspaa
ISSUE fmidev#80
7bdad7b 
Add bulletin parser tests and test resources for IWXXM 3.0 regular and cancellation message parsing.
@patrick-alaspaa
SSUE fmidev#80
3a59fb0 
Add IWXXM builletin parsing to configurations
@patrick-alaspaa
ISSUE fmidev#80
7a656a9 
Add IWXXM 3.0 parsing to IWXXMGenericBulletinScanner. Refactor small parts of code for less code repetition.
@patrick-alaspaa
ISSUE fmidev#80
d311e31 
Code style fixes
@patrick-alaspaa patrick-alaspaa changed the title Fmi avi messageconverter iwxxm 80 Fmi avi messageconverter iwxxm #80 Jun 4, 2021
@petringo petringo linked an issue Jun 4, 2021 that may be closed by this pull request
IWXXM 3.0.0 messages to generic POJO conversion #80
Closed
@petringo petringo self-assigned this Jun 17, 2021
@petringo petringo self-requested a review June 17, 2021 11:47
petringo
petringo requested changes Jun 17, 2021
View reviewed changes
Copy link
Contributor

@petringo petringo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work very well. I think there are few things that still could be done to increase reliability and usability.

src/main/java/fi/fmi/avi/converter/iwxxm/bulletin/v1_2/IWXXMGenericBulletinScanner.java Outdated Show resolved Hide resolved
src/main/java/fi/fmi/avi/converter/iwxxm/conf/IWXXMConverter.java Outdated Show resolved Hide resolved
src/test/java/fi/fmi/avi/converter/iwxxm/bulletin/v1_2/GenericBulletinParserTest.java Show resolved Hide resolved
@patrick-alaspaa
CR: Add illegal argument exception
70ebfeb
@patrick-alaspaa
CR:
d0856bd 
Rename IWXXM21_DOM_TO_GENERIC_BULLETIN_POJO -> WMO_COLLECT_DOM_TO_GENERIC_BULLETIN_POJO &&
IWXXM21_STRING_TO_GENERIC_BULLETIN_POJO -> WMO_COLLECT_STRING_TO_GENERIC_BULLETIN_POJO. Remove IWXXM30_DOM_TO_GENERIC_BULLETIN_POJO and replace references with WMO_COLLECT_DOM_TO_GENERIC_BULLETIN_POJO.
@patrick-alaspaa
Add checks for some missing properties
68cdd61
@patrick-alaspaa
Merge branch 'feature-archiver-v1.0-support' into fmi-avi-messageconv…
9874e8b 
…erter-iwxxm-80
@patrick-alaspaa
Fix tests that failed do to code merge from feature-archiver-v1.0-sup…
20032b1 
…port branch
@patrick-alaspaa
Add issue time to test aserion
22d2955
@patrick-alaspaa patrick-alaspaa requested a review from petringo June 18, 2021 09:04
@patrick-alaspaa
CR Fix
8861216 
Remove part of javadoc comment added by me in the last code review. It was a confudiion with IWXXM versions
@patrick-alaspaa
CR fixes
004930b 
Add assertions for message type and format. Modify some assertions that handle optionals
@patrick-alaspaa patrick-alaspaa requested a review from petringo June 22, 2021 09:07
@petringo petringo merged commit 004930b into fmidev:feature-archiver-v1.0-support Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petringo petringo petringo approved these changes

Assignees

@petringo petringo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IWXXM 3.0.0 messages to generic POJO conversion
2 participants
@patrick-alaspaa @petringo