Added else branches to if constexpr statements to silence MSVC

fmtlib · May 23, 2024 · 0c30380 · 0c30380
1 parent b817610
commit 0c30380
Showing 1 changed file with 10 additions and 3 deletions.
diff --git a/include/fmt/base.h b/include/fmt/base.h
@@ -2709,8 +2709,10 @@ constexpr auto get_arg_index_by_name(basic_string_view<Char> name) -> int {
   }
   if constexpr (sizeof...(Args) > 0)
     return get_arg_index_by_name<N + 1, Args...>(name);
-  (void)name;  // Workaround an MSVC bug about "unused" parameter.
-  return -1;
+  else {
+    (void)name;  // Workaround an MSVC bug about "unused" parameter.
+    return -1;
+  }
 }
 #endif
 
@@ -2719,9 +2721,14 @@ FMT_CONSTEXPR auto get_arg_index_by_name(basic_string_view<Char> name) -> int {
 #if FMT_USE_NONTYPE_TEMPLATE_ARGS
   if constexpr (sizeof...(Args) > 0)
     return get_arg_index_by_name<0, Args...>(name);
-#endif
+  else {
+    (void)name;
+    return -1;
+  }
+#else
   (void)name;
   return -1;
+#endif
 }
 
 template <typename Char, typename... Args> class format_string_checker {