Explicitly cast int -> char to prevent conversion warnings

fmtlib · Aug 20, 2017 · 9e15ef7 · 9e15ef7
1 parent 032c838
commit 9e15ef7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/fmt/format.h b/fmt/format.h
@@ -1681,7 +1681,7 @@ class ArgVisitor {
     case Arg::BOOL:
       return FMT_DISPATCH(visit_bool(arg.int_value != 0));
     case Arg::CHAR:
-      return FMT_DISPATCH(visit_char(arg.int_value));
+      return FMT_DISPATCH(visit_char(static_cast<char>(arg.int_value)));
     case Arg::DOUBLE:
       return FMT_DISPATCH(visit_double(arg.double_value));
     case Arg::LONG_DOUBLE:

diff --git a/fmt/printf.h b/fmt/printf.h
@@ -110,7 +110,7 @@ class ArgConverter : public ArgVisitor<ArgConverter<T>, void> {
       visit_any_int(value);
   }
 
-  void visit_char(char value) {
+  void visit_char(int value) {
     if (type_ != 's')
       visit_any_int(value);
   }