Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BasicStringRef comparison operators should compare string content, not pointers #183

Closed
vitaut opened this issue Jun 26, 2015 · 1 comment
Closed

BasicStringRef comparison operators should compare string content, not pointers #183

vitaut opened this issue Jun 26, 2015 · 1 comment

Comments

@vitaut
Copy link
Contributor

vitaut commented Jun 26, 2015

As pointed out by @CarterLi in #100, BasicStringRef

Compares pointer instead of value in operator ==
@vitaut vitaut mentioned this issue Jun 26, 2015
Closed
vitaut added a commit that referenced this issue Oct 22, 2015
@vitaut
Implement StringRef comparison operators
f080b62 
and use lexicographical comparison (#183)
@vitaut
Copy link
Contributor Author

vitaut commented Oct 22, 2015

Fixed in f080b62.

@vitaut vitaut closed this as completed Oct 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vitaut