Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing explicit instantiation for format_float<double> and <long double> #413

Closed
Smjert opened this issue Nov 5, 2016 · 0 comments
Closed

Comments

@Smjert
Copy link

Smjert commented Nov 5, 2016

I've compiled fmt(7ce7def) as a shared library with Clang 3.9.0, when i include the fmt/format.h header in my project clang warns about format_float for double and long double not being explicitly instantiated.

Now my guess is that since it is explicitly instantiated in the format.cc, but where i'm using the function is not the same TU, it needs to be either explicitly instantiated again (by me) or even better format.h should contain an extern template declaration (i did that and the warning went away), because the template is effectively instantiated "somewhere else".

foonathan added a commit that referenced this issue Jun 8, 2017

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Fixes #413.

(cherry picked from commit 6c01257)
vitaut added a commit that referenced this issue Jan 21, 2018

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant