Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

name conflict of False #483

Closed
zhaohuaxishi opened this issue Mar 7, 2017 · 2 comments
Closed

name conflict of False #483

zhaohuaxishi opened this issue Mar 7, 2017 · 2 comments

Comments

@zhaohuaxishi
Copy link

if i include <X11/Xlib.h> before format.h, compile will complain:

../../src/contrib/fmt/format.h:1209:8: error: expected identifier before numeric constant
 struct False { enum { value = 0 }; };

but if i exchange the include order, everything will be fine.

it seems that <X11/Xlib.h> has defined False as value 0.

is name False too common to be a type identifier in header file.

@FrankStain
Copy link

@zhaohuaxishi , can you check the False is a macro in <X11/Xlib.h> or not?

vitaut added a commit that referenced this issue Mar 8, 2017
@vitaut
Copy link
Contributor

vitaut commented Mar 8, 2017

Fixed in fbc8ea8, thanks for reporting!

@vitaut vitaut closed this as completed Mar 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants