Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Major release prep #940

Closed
9 tasks done
vitaut opened this issue Nov 21, 2018 · 2 comments
Closed
9 tasks done

Major release prep #940

vitaut opened this issue Nov 21, 2018 · 2 comments

Comments

@vitaut
Copy link
Contributor

vitaut commented Nov 21, 2018 •
edited
Loading

Things that need to be done in the next major release (because they are API breaking and cannot be done right now):

  • Remove context_base::begin.
  • Remove arg_formatter(context_type &ctx, format_specs &spec).
  • Remove context_base::args().
  • Refactor undocumented format_specs API to make its components follow naming conventions and support a variable-width fill.
  • Remove deprecated color formatting.
  • Remove fmt::visit.
  • Merge time.h into chrono.h and remove the former because it may collide with system's time.h if users specify include directories incorrectly.
  • Move basic_writer, writer, and wwriter to the internal namespace, since they are an implementation detail as of version 5.
  • Replace workarounds for lack of alias templates with proper alias templates.
@vitaut vitaut mentioned this issue Nov 27, 2018
Closed
@Rakete1111
Copy link
Contributor

Can we add "Remove deprecated color formatting" to the list?

@vitaut
Copy link
Contributor Author

vitaut commented Dec 9, 2018

Can we add "Remove deprecated color formatting" to the list?

Done.

vitaut added a commit that referenced this issue Jul 7, 2019
@vitaut
Refactor format_specs for #1109 and #940
4967a70 
Refactor `format_specs` and related APIs to support variable-width fill
(#1109), improve naming consistency, and remove legacy setters (#940).
vitaut added a commit that referenced this issue Jul 7, 2019
@vitaut
Refactor format_specs for #1109 and #940
85e0022 
Refactor `format_specs` and related APIs to support variable-width fill
(#1109), improve naming consistency, and remove legacy setters (#940).
vitaut added a commit that referenced this issue Jul 7, 2019
@vitaut
Refactor format_specs for #1109 and #940
80ff855 
Refactor `format_specs` and related APIs to support variable-width fill
(#1109), improve naming consistency, and remove legacy setters (#940).
vitaut added a commit that referenced this issue Jul 7, 2019
@vitaut
Refactor format_specs for #1109 and #940
cfb128e 
Refactor `format_specs` and related APIs to support variable-width fill
(#1109), improve naming consistency, and remove legacy setters (#940).
vitaut added a commit that referenced this issue Jul 7, 2019
@vitaut
Refactor format_specs for #1109 and #940
a5e9345 
Refactor `format_specs` and related APIs to support variable-width fill
(#1109), improve naming consistency, and remove legacy setters (#940).
vitaut added a commit that referenced this issue Jul 7, 2019
@vitaut
Refactor format_specs for #1109 and #940
e4f75a3 
Refactor `format_specs` and related APIs to support variable-width fill
(#1109), improve naming consistency, and remove legacy setters (#940).
vitaut added a commit that referenced this issue Jul 7, 2019
@vitaut
Refactor format_specs for #1109 and #940
89bf932 
Refactor `format_specs` and related APIs to support variable-width fill
(#1109), improve naming consistency, remove legacy setters (#940), and
optimize layout.
vitaut added a commit that referenced this issue Jul 7, 2019
@vitaut
Refactor format_specs for #1109 and #940
24d4f31 
Refactor `format_specs` and related APIs to support variable-width fill
(#1109), improve naming consistency, remove legacy setters (#940), and
optimize layout.
vitaut added a commit that referenced this issue Jul 7, 2019
@vitaut
Refactor format_specs for #1109 and #940
b25d5b3 
Refactor `format_specs` and related APIs to support variable-width fill
(#1109), improve naming consistency, remove legacy setters (#940), and
optimize layout.
vitaut added a commit that referenced this issue Jul 7, 2019
@vitaut
Refactor format_specs for #1109 and #940
b955f45 
Refactor `format_specs` and related APIs to support variable-width fill
(#1109), improve naming consistency, remove legacy setters (#940), and
optimize layout.
vitaut added a commit that referenced this issue Jul 7, 2019
@vitaut
Refactor format_specs for #1109 and #940
e4f84ee 
Refactor `format_specs` and related APIs to support variable-width fill
(#1109), improve naming consistency, remove legacy setters (#940), and
optimize layout.
@vitaut vitaut closed this as completed Jul 7, 2019
@vitaut vitaut reopened this Jul 7, 2019
vitaut added a commit that referenced this issue Jul 7, 2019
@vitaut
Remove gcc 4.4 workaround and use proper alias templates (#940)
e3f20d3
@vitaut vitaut closed this as completed Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vitaut @Rakete1111