Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your great work and the great fmt library.
I have a small problem. When I cross-compile (with dockcross/linux-armv7 https://github.com/dockcross/dockcross to Raspberry Pi ARMv7) my source code with your fmt-library, I receive this warning:
Not using the -Wconversion flag is not an option because I want to use the flag to detect as many errors as possible.
And I'm not able to configure CMake, CPMAddPackage and
target_include_directories
+SYSTEM
correctly to ignore warnings from your library 🙈.My solution (adding const_cast<size_t>) works for me but I don't know if this is a clean solution. I'm not a C++ expert.