-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
quotes for string support. #763
Conversation
…anges.h and some tests.
Renames namespace meta to internal and put copy functions int it. Replaced constexpr by FMT_CONSTEXPR. Replaced std::ptrdiff_t by std::size_t.
Replaced std::enable_if_t by std::std::enable_if<>::type. Replaced variable templates by structs.
Added add_delimiter_spaces and add_prepostfix_space.
# Conflicts resolved: # include/fmt/ranges.h # test/ranges-test.cc
Moved is_tuple_like and is_range to fmt namespace.
Thanks for the PR! I suggest using double quotes ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting changes per earlier comment.
I made a new clear PR with all the changes. |
Thanks! |
std::string and types like it are not printed in single quotes
'str'
.fmt::is_range and fmt::is_tuple_like are now in fmt namespace.