Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quotes for string support. #763

Closed
wants to merge 22 commits into from
Closed

quotes for string support. #763

wants to merge 22 commits into from

Conversation

Remotion
Copy link
Contributor

@Remotion Remotion commented Jun 6, 2018

std::string and types like it are not printed in single quotes 'str'.
fmt::is_range and fmt::is_tuple_like are now in fmt namespace.

#include <tuple>
#include <vector>
#include <string_view>

#define FMT_HEADER_ONLY
#include <fmt/format.h>
#include <fmt/ranges.h>
#include <fmt/printf.h>

int main() {
    std::tuple tup = {1, '1', "10", std::string("20"), std::string_view{"30"}};
    fmt::print("{}\n", tup);

    std::vector vec = {'1', '2'};
    fmt::print("{}\n", vec);

    std::vector vec2 = {"2", "3"};
    fmt::print("{}\n", vec2);
}

@vitaut
Copy link
Contributor

vitaut commented Jun 7, 2018

Thanks for the PR! I suggest using double quotes ("...") for consistency with C++ strings. Also could you rebase getting rid of multiple "Merge branch ..." commits?

Copy link
Contributor

@vitaut vitaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes per earlier comment.

@Remotion Remotion closed this Jun 7, 2018
@Remotion
Copy link
Contributor Author

Remotion commented Jun 7, 2018

I made a new clear PR with all the changes.

@vitaut
Copy link
Contributor

vitaut commented Jun 8, 2018

I made a new clear PR with all the changes.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants