Parameterize printf functions on the type of the format string. #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielaE
force-pushed
the
feature/parameterize-printf
branch
from
01c5a86 to
f1cb720
Compare
vitaut
requested changes
Oct 7, 2018
include/fmt/printf.h
Outdated
| args...); | ||
| } | ||
| typedef basic_format_args<printf_context<internal::buffer>::type> printf_args; | ||
| typedef basic_format_args<printf_context<internal::wbuffer>::type> wprintf_args; |
There was a problem hiding this comment.
Removing printf_args and wprintf_args might break users' code. I suggest keeping them.
DanielaE
force-pushed
the
feature/parameterize-printf
branch
from
f1cb720 to
7c9dd4b
Compare
Signed-off-by: Daniela Engert <[email protected]>
DanielaE
force-pushed
the
feature/parameterize-printf
branch
from
7c9dd4b to
d0b0ff4
Compare
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniela Engert [email protected]