Smooth Ely.by -> authlib-injector migration #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Evan Goode <[email protected]>
fn2006
approved these changes
Nov 15, 2023
There was a problem hiding this comment.
Great work, it's like you read my mind. I thought about adding something like this myself when I saw how loadFromJsonV3 worked while I was reviewing #116.
As for Ely.by's 2FA system I think I'll add a note about it in it's description on the alternative auth servers page. As far as I'm aware there's no other API server that implements 2FA like that so I don't think the separate input field should be reimplemented just for one server.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically migrate Ely.by accounts to authlib-injector.
Is there anything else we should do so Ely.by users aren't as confused about the update? #116 (comment) mentions that the 2FA field is no longer there. We could add it back, but who knows whether other auth servers also implement 2FA the same way, it might not make sense long-term.
Maybe an additional message specifically explaining 2FA on Ely.by on the "Add authlib-injector" dialog would be best.