Ensure only initialised values are serialised. #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For performance reasons Lua does not initialise memory until it knows the values will actually be used. However Eris serializes some of them without knowing whether they have been initialised, causing harmless (but verbose) Valgrind memory check errors.
|
While debugging Eris I have come across a few Valgrind warnings about uninitialised call info memory being serialised. This is harmless but does pollute error reporting when investigating issues, so I thought I’d suggest the attached changes for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For performance reasons Lua does not initialise memory until it knows
the values will actually be used. However Eris serializes some of them
without knowing whether they have been initialised, causing harmless
(but verbose) Valgrind memory check errors.