JournaledDAO operations fails on node v4.x

[drish]

@mdittmer I found the reason why the journaled dao tests were only failing on node v4.x.

nodejs/node#5862

on node v4.x fs.readFile were only understanding file names instead of file names and file descriptors as the JournaledDAO is currently using, making it fail on node v4.x

should I go ahead and tweak the journaled dao implementation to something that accommodates node v4.x too ? or is it not a big deal at this moment ?

cc @adamvy @mdittmer

[kgrgreer]

@drish Go ahead if it can be done easily, but otherwise, do we have any real need to support v4? I think we can just make v6+ be a requirement.

[mdittmer]

I think this is fine. @jacksonic do you want to update our Travis CI config to stop building 4, 5, and 6?

[adamvy]

On May 15, 2017 3:02:05 PM EDT, Mark Dittmer ***@***.***> wrote: I think this is fine. @jacksonic do you want to update our Travis CI config to stop building 4, 5, and 6? -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #356 (comment)

Keep building 6 We should support nodejs LTS and nodejs latest.

[jacksonic]

Removing Node4 build.

…

On Mon, May 15, 2017 at 3:04 PM adamvy ***@***.***> wrote: On May 15, 2017 3:02:05 PM EDT, Mark Dittmer ***@***.***> wrote: >I think this is fine. @jacksonic do you want to update our Travis CI >config to stop building 4, 5, and 6? > >-- >You are receiving this because you were mentioned. >Reply to this email directly or view it on GitHub: >#356 (comment) Keep building 6 We should support nodejs LTS and nodejs latest. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#356 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIKjMNNvzfY5fexdvrB5Oa1uqFPnDU4Fks5r6KGigaJpZM4NanAf> .

[drish]

thanks, making journaled dao to support v4 would probably break the api, since atm journaled dao works with file descriptors.

[drish]

once node v4 are disabled I can re enable journaled dao tests.